Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/7 new scene instances #8

Merged
3 commits merged into from
Apr 24, 2015
Merged

Bug/7 new scene instances #8

3 commits merged into from
Apr 24, 2015

Conversation

macskay
Copy link
Owner

@macskay macskay commented Apr 24, 2015

Bug 7 fixed:

  • register_new_scene now takes a scene argument, which have to be off type Scene() or subclass of Scene()

Max added 3 commits April 24, 2015 18:52
New branch
16e43d6
Bug 7 fixed.
fb1d205 
 - register_new_scene now takes a scene argument, which can be subclasses of Scene()

 Minor fixes.
  - added some more tests (testing zero call of get_top_scene raises an error)
  - all scenes get an updated "registered_scenes" when a new scene gets registered
Bug 7 fixed #2:
feff93e 
 - push_scene_on_stack now gets an "ident"-string and looks up the respective scene in the "registered_scenes"-dictionary.
 - Only strings are allowed as parameters of push_scene_on_stack
 - Scenes can only get pushed, if they are registered beforehand
ghost pushed a commit that referenced this pull request Apr 24, 2015
@mindfilleter
Merge pull request #8 from mkli90/bug/7-new-scene-instances
c316e21 
Bug/7 new scene instances. Closes #7
@ghost ghost merged commit c316e21 into master Apr 24, 2015
@macskay macskay deleted the bug/7-new-scene-instances branch April 24, 2015 18:34
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@macskay