Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

81a64f introduced double width for some single width characters #184

Closed
HealsCodes opened this issue Dec 22, 2015 · 4 comments
Closed

81a64f introduced double width for some single width characters #184

HealsCodes opened this issue Dec 22, 2015 · 4 comments
Assignees

Comments

@HealsCodes
Copy link
Contributor

I recently became aware of this thread in the mac_vim list.

In summary a user is complaining that suddenly his supplementary characters are rendered double width but should in fact be rendered single width.

I noticed the same for status characters used by a plugin in my setup.
Here's a screenshot of the issue:

double width bug

After some bisecting I discovered the issue was introduced in 81a64f5 which implemented Emoji support.
The problem seems to be a result of a few new and changed, but now too generous, character ranges in src/mbyte.c.

Reverting only the changes to that file I get this:

correct rendering

I had a look at the unicode ranges for Emoji and - apart for the big Emoji block U+1F300+ - they are scattered across blocks in U+2300/U+2500/U+2600 und U+2700.

A proposed fix might be to check the output of runtime/unicode.vim and add the Emoji code points to the resulting doublewidth-table replacing the catch-all blocks that we have now.

@splhack splhack self-assigned this Dec 22, 2015
@splhack
Copy link
Contributor

splhack commented Dec 22, 2015

I'll change mbyte.c.

@HealsCodes
Copy link
Contributor Author

Anything I can give you a hand with?

I tried it myself but for some reason my test builds would sometimes stop displaying multibyte characters correctly at all..

Am 22.12.2015 um 22:59 schrieb Kazuki Sakamoto notifications@github.com:

I'll change mbyte.c.


Reply to this email directly or view it on GitHub.

splhack added a commit that referenced this issue Dec 25, 2015
@splhack
Copy link
Contributor

splhack commented Dec 25, 2015

#187

splhack added a commit that referenced this issue Dec 25, 2015
@splhack splhack closed this as completed Dec 25, 2015
@splhack
Copy link
Contributor

splhack commented Dec 25, 2015

You can install the latest MacVim using https://github.com/macvim-dev/homebrew-macvim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants