This repository has been archived by the owner on Mar 16, 2020. It is now read-only.
favicons broken #305
Comments
|
This might be the same issue as #289. I notice that when I visit the admin page for a feed the |
mblakele
added a commit
to mblakele/goread
that referenced
this issue
Dec 13, 2014
… URL alone. Test case: http://www.sheldoncomics.com/index.xml Actual favicon http://www.sheldoncomics.com/favicon.ico Requests to https://www.sheldoncomics.com/favicon.ico time out.
maddyblue
added a commit
that referenced
this issue
Dec 15, 2014
#305 Many favicons are only available via HTTP, so leave the URL alone.
|
Should be fixed by #316 |
|
I just rebuilt on 60e82ac and the favicons are working again. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Since updating to commit 4d2df60 the feed icons on the left are mostly missing/broken. With Boing Boing, for example, goread is trying to get https://boingboing.net/favicon.ico but port 443 is not available on boingboing.net. If I manually get http://boingboing.net/favicon.ico that does work.
Seems like goread should use the scheme (http/https) of the feed when getting favicons rather than using "//" prefixed URLs that inherit its own scheme.
The text was updated successfully, but these errors were encountered: