Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couplings order #918

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Couplings order #918

merged 3 commits into from
Jul 29, 2024

Conversation

oliviermattelaer
Copy link
Member

This is based on the work of @roiser (thanks so much for it).
Trying to avoid to do what I suggest him to do (i.e. avoiding global variable).

Putting this in PR to have the CI/CD.
Next step here would be to merge my new test to check other problematic process (to see if it was the same issue)

@oliviermattelaer oliviermattelaer marked this pull request as ready for review July 17, 2024 20:31
@oliviermattelaer
Copy link
Member Author

SO this

  • fix the missmatch for stop pair production (confirmed by the CI )
  • The status of the CI (non merged one) for e+ e- > mu+ mu- a should be consider as fixed (i.e. LTS agree with current value BUT only if setting sde_strategy=1... So they are a bug in LTS and not in the plugin for this process. So the CI might have been checking the value for sde_strategy=2, explaining the report, anyway this can be consider as fixed for this plugin.
  • The CI for g g > t t~ 2g is still crashing (need investigation)

This is not as good as we would have like, but this is progress :-D
So I remove the draft status on this one.

@oliviermattelaer oliviermattelaer added the bug Something isn't working label Jul 18, 2024
valassi added a commit to valassi/madgraph4gpu that referenced this pull request Jul 22, 2024
valassi added a commit to valassi/madgraph4gpu that referenced this pull request Jul 22, 2024
madgraph5#918 - confirms that only susy_gg_t1t1 code has been affected
@valassi
Copy link
Member

valassi commented Jul 22, 2024

Thanks @oliviermattelaer @roiser this is good to go for me.
I only checked that the susy_gg_t1t1 issue #826 is fixed, but that is confirmed.
(I attached this PR to #826 about susy and #862 about generic couplings order)
Out of the processes generated in the repo, this is the only one whose code changes.

I have opened #934 where I added code generation and I will add a few more tests.
I would prefer to merge this only after we merge also the code generation from #934.

@valassi valassi linked an issue Jul 22, 2024 that may be closed by this pull request
@valassi valassi linked an issue Jul 22, 2024 that may be closed by this pull request
valassi added a commit to valassi/madgraph4gpu that referenced this pull request Jul 23, 2024
valassi added a commit to valassi/madgraph4gpu that referenced this pull request Jul 23, 2024
madgraph5#918 - confirms that only susy_gg_t1t1 code has been affected
@valassi
Copy link
Member

valassi commented Jul 24, 2024

This is also related to #748 (xsec mismatch in gqttq, which was also due to ther order of couplings)

@valassi
Copy link
Member

valassi commented Jul 29, 2024

Thanks Olivier for approving #934 :-)

I will merge this one and then merge #934.

Andrea

@valassi valassi merged commit dfe59f1 into master Jul 29, 2024
166 of 169 checks passed
valassi added a commit to valassi/madgraph4gpu that referenced this pull request Jul 29, 2024
…rder madgraph5#918, and smaller patch madgraph5#939 and madgraph5#849) into susy2

Note: there is no change with respect to the previous origin/susy2 after this merge (no need to rerun the CI)
valassi added a commit to valassi/madgraph4gpu that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coupling ordering issue? No cross section in SUSY gg_t1t1 log file
3 participants