Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if docker is not installed and proceed #92

Merged
merged 2 commits into from
Mar 5, 2019
Merged

check if docker is not installed and proceed #92

merged 2 commits into from
Mar 5, 2019

Conversation

aquibbaig
Copy link
Contributor

@aquibbaig aquibbaig commented Mar 4, 2019 •
edited
Loading

This is an intial PR that solves #71

@aquibbaig aquibbaig closed this Mar 4, 2019
@aquibbaig aquibbaig reopened this Mar 4, 2019
@madlabsinc madlabsinc deleted a comment from request-info bot Mar 4, 2019
jamesgeorge007
jamesgeorge007 reviewed Mar 4, 2019
View reviewed changes
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use {silent: true} with shell.exec() so as to prevent logging the output.

lib/commands/deploy/docker.js Show resolved Hide resolved
@aquibbaig
Copy link
Contributor Author

@jamesgeorge007 I have made the changes you had asked. Can you check the logs and tell me why the build checks are failing?

@ajomadlabs
Copy link
Collaborator

@aquibbaig Have fixed the build issue

ajomadlabs
ajomadlabs approved these changes Mar 5, 2019
View reviewed changes
Copy link
Collaborator

@ajomadlabs ajomadlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ajomadlabs ajomadlabs merged commit 93cb7fc into madlabsinc:master Mar 5, 2019
@anto-christo anto-christo mentioned this pull request Mar 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesgeorge007 jamesgeorge007 jamesgeorge007 left review comments

@ajomadlabs ajomadlabs ajomadlabs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aquibbaig @ajomadlabs @jamesgeorge007