chore: e2e test case for fetchtask #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabhKalakoti
changed the title
jamesgeorge007
changed the title
jamesgeorge007
requested changes
Jan 9, 2020
jamesgeorge007
requested changes
Jan 9, 2020
jamesgeorge007
changed the title
jamesgeorge007
changed the title
jamesgeorge007
approved these changes
Jan 9, 2020
jamesgeorge007
added a commit
that referenced
this pull request
Apr 16, 2020
* chore: e2e test case for fetchtask (#64) * test: e2e test for fetchtask (incorrect tests/ code) * refactor: replaced var by let * test: tests giving incorrect snaps, 'incomplete tasks' and 'next task' * refactor: updated code to not reject promises when task is printed * refactor: tasks.js updated * fix: deleted extra files created * refactor: style update * refactor: style changes * refactor: destructuring * chore: audit deps * Simplify PR Template (#75) * docs: improvise PR template * docs: update PR template Co-authored-by: James George <jamesgeorge998001@gmail.com> * chore(deps): [security] bump acorn from 6.1.1 to 6.4.1 (#77) Bumps [acorn](https://github.com/acornjs/acorn) from 6.1.1 to 6.4.1. **This update includes a security fix.** - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@6.1.1...6.4.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * chore: audit deps * refactor: use object literal rather than an array * chore: minor tweak * fix: regression with create repository implemenation (#80) * fix: regression consume GitHub API the recommended way * fix: lint Co-authored-by: jamesgeorge007 <jamesgeorge998001@gmail.com> * chore: drop showcommands (#82) * refactor: dropping showcommands as per #72 * chore: drop cli-table * refactor: avoid newline character Co-authored-by: jamesgeorge007 <jamesgeorge998001@gmail.com> * 1.3.0-beta.0 * test: update snapshots * refactor: remove unreachable code * chore: add ora spinner * refactor: format config file * refactor: dead code elimination * refactor: stick to best practices * test: update snapshots * chore: better logs * docs: update info relating to fetchtask command * test: update snapshots * docs: remove information concerning showcommands * docs: update info * 1.3.0 * test: update snapshots Co-authored-by: Rishabh Kalakoti <23037053+rishabhKalakoti@users.noreply.github.com> Co-authored-by: Annu <annujolly17@gmail.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Abhijith Neil Abraham <abhijithneilabrahampk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
e2e tests for
fetchtask [key]fetchtaskfetchtaskfetchtask keyfetchtask keyfetchtaskAs of now the tests are not working as desired especially for the cases where all tasks have been solved.All tests working correctly
#57 introduced a few bugs which have now been fixed.
addresses #28
Type of change