Make sure the zlib cmake do not pollute the working directly. #162

lygstate · 2016-09-14T17:21:21Z

No description provided.

praiskup · 2016-09-15T09:22:02Z

s/directly/directory/? Yes:

chmod -R -w .
cd ..
mkdir builddir && cd builddir
cmake ../zlib
...
CMake Error at CMakeLists.txt:77 (file):
  file RENAME failed to rename

    /tmp/zlib/zconf.h

  to

    /tmp/zlib/zconf.h.included

  because: Permission denied

praiskup · 2016-09-15T09:23:03Z

However reading FAQ:

 7. Why don't you use GNU autoconf or libtool or ...?

    Because we would like to keep zlib as a very small and simple package.
    zlib is rather portable and doesn't need much configuration.

I doubt cmake is needed at all.

lygstate · 2016-09-15T17:53:00Z

@praiskup Under win32, cmake is far more better usable than autoonf or libtool

praiskup · 2016-09-16T07:03:42Z

@lygstate that's possible, I'm not able to confirm though. What I tried to say is, when autotools are not needed, most probably neither cmake is.

BusyJay · 2017-07-04T13:55:44Z

+1 for this. I have a project include zlib as submodule. Every time I build my project, it will show that the zlib submodule is in dirty state, which is very annoying.

pull requests through Travis CI and Appveyor. Fix cygwin build issues. This fixes madler#162

pull requests through Travis CI and Appveyor. Fix cygwin build issues. Recommend everyone use cmake to generate build environments, and consider checked-in projects or makefiles to be deprecated. The generated build will always be correct, and proven by CI. This fixes madler#162 This fixes madler#238 This fixes madler#307

jeking3 · 2017-11-23T14:39:46Z

Yikes, sorry for the spam... I didn't realize it would post something with every force push.

When using the built-in cmake to build zlib, it changes the source tree as madler/zlib#162 describes. This leads to the failure during [generating the docs][1]. So let's switch to libz-sys instead, which uses its own custom script to build zlib, and leave source tree as it is. Switching to libz-sys can also reduce the package size as we can ignore more sub modules. It should improve compile time if libz-sys is also a dependency of other crates. The only shortcomming is that libz-sys may not be compitable with grpcio, but I believe the chance is quite small given it's such a small library. [1]: https://docs.rs/crate/grpcio/0.5.0-alpha.5/builds/196235. Signed-off-by: Jay Lee <busyjaylee@gmail.com>

When using the built-in cmake to build zlib, it changes the source tree as madler/zlib#162 describes. This leads to the failure during [generating the docs][1]. So let's switch to libz-sys instead, which uses its own custom script to build zlib, and leave source tree as it is. Switching to libz-sys can also reduce the package size as we can ignore more sub modules. It should improve compile time if libz-sys is also a dependency of other crates. The only shortcoming is that libz-sys may not be compatible with grpcio, but I believe the chance is quite small given it's such a small library. And giving it's such a small library, the benifits like compile time or package size described above may to too small to be observed. [1]: https://docs.rs/crate/grpcio/0.5.0-alpha.5/builds/196235. Signed-off-by: Jay Lee <busyjaylee@gmail.com>

When using the built-in cmake to build zlib, it changes the source tree as madler/zlib#162 describes. This leads to the failure during [generating the docs][1]. So let's switch to libz-sys instead, which uses its own custom script to build zlib, and leave source tree as it is. Switching to libz-sys can also reduce the package size as we can ignore more sub modules. It should improve compile time if libz-sys is also a dependency of other crates. The only shortcoming is that libz-sys may not be compatible with grpcio, but I believe the chance is quite small given it's such a small library. And giving it's such a small library, the benifits like compile time or package size described above may be too small to be observed. [1]: https://docs.rs/crate/grpcio/0.5.0-alpha.5/builds/196235. Signed-off-by: Jay Lee <busyjaylee@gmail.com>

When using the built-in cmake to build zlib, it changes the source tree as madler/zlib#162 describes. This leads to the failure during [generating the docs][1]. So let's switch to libz-sys instead, which uses its own custom script to build zlib, and leave source tree as it is. Switching to libz-sys can also reduce the package size as we can ignore more sub modules. It should improve compile time if libz-sys is also a dependency of other crates. The only shortcoming is that libz-sys may not be compatible with grpcio, but I believe the chance is quite small given it's such a small library. And giving it's such a small library, the benefits like compile time or package size described above may be too small to be observed. [1]: https://docs.rs/crate/grpcio/0.5.0-alpha.5/builds/196235. Signed-off-by: Jay Lee <busyjaylee@gmail.com>

* *: use libz-sys instead of bundled one When using the built-in cmake to build zlib, it changes the source tree as madler/zlib#162 describes. This leads to the failure during [generating the docs][1]. So let's switch to libz-sys instead, which uses its own custom script to build zlib, and leave source tree as it is. Switching to libz-sys can also reduce the package size as we can ignore more sub modules. It should improve compile time if libz-sys is also a dependency of other crates. The only shortcoming is that libz-sys may not be compatible with grpcio, but I believe the chance is quite small given it's such a small library. And giving it's such a small library, the benifits like compile time or package size described above may be too small to be observed. [1]: https://docs.rs/crate/grpcio/0.5.0-alpha.5/builds/196235. Signed-off-by: Jay Lee <busyjaylee@gmail.com>

inkychris · 2022-09-23T11:12:34Z

The way CMake is currently set up, the name conflict in the source directory doesn't actually matter, the header path for zconf.h is already defined as ${CMAKE_CURRENT_BINARY_DIR}/zconf.h so we can just remove the renaming here

zlib/CMakeLists.txt

Lines 69 to 79 in 21767c6

    
           if(NOT CMAKE_CURRENT_SOURCE_DIR STREQUAL CMAKE_CURRENT_BINARY_DIR) 
        
               # If we're doing an out of source build and the user has a zconf.h 
        
               # in their source tree... 
        
               if(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/zconf.h) 
        
                   message(STATUS "Renaming") 
        
                   message(STATUS "    ${CMAKE_CURRENT_SOURCE_DIR}/zconf.h") 
        
                   message(STATUS "to 'zconf.h.included' because this file is included with zlib") 
        
                   message(STATUS "but CMake generates it automatically in the build directory.") 
        
                   file(RENAME ${CMAKE_CURRENT_SOURCE_DIR}/zconf.h ${CMAKE_CURRENT_SOURCE_DIR}/zconf.h.included) 
        
             endif() 
        
           endif()

jeking3 pushed a commit to jeking3/zlib that referenced this issue Nov 23, 2017

Add continuous integration support for GitHub

f03529f

pull requests through Travis CI and Appveyor. Fix cygwin build issues. This fixes madler#162

jeking3 pushed a commit to jeking3/zlib that referenced this issue Nov 23, 2017

Add continuous integration support for GitHub

eef6ba6

pull requests through Travis CI and Appveyor. Fix cygwin build issues. This fixes madler#162

jeking3 pushed a commit to jeking3/zlib that referenced this issue Nov 23, 2017

Add continuous integration support for GitHub

639a56d

pull requests through Travis CI and Appveyor. Fix cygwin build issues. This fixes madler#162

BusyJay mentioned this issue Dec 2, 2017

add reset-submodule script tikv/grpc-rs#122

Merged

BusyJay mentioned this issue Dec 20, 2019

*: use libz-sys instead of bundled one tikv/grpc-rs#419

Merged

inkychris mentioned this issue Sep 23, 2022

Remove source modification from CMake configuration #713

Open

inkychris mentioned this issue Sep 23, 2022

Never ever edit files in source directory #600

Open

Neustradamus mentioned this issue Jan 25, 2024

CMake and Zlib #831

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make sure the zlib cmake do not pollute the working directly. #162

Make sure the zlib cmake do not pollute the working directly. #162

lygstate commented Sep 14, 2016

praiskup commented Sep 15, 2016

praiskup commented Sep 15, 2016

lygstate commented Sep 15, 2016

praiskup commented Sep 16, 2016

BusyJay commented Jul 4, 2017

jeking3 commented Nov 23, 2017

inkychris commented Sep 23, 2022

Make sure the zlib cmake do not pollute the working directly. #162

Make sure the zlib cmake do not pollute the working directly. #162

Comments

lygstate commented Sep 14, 2016

praiskup commented Sep 15, 2016

praiskup commented Sep 15, 2016

lygstate commented Sep 15, 2016

praiskup commented Sep 16, 2016

BusyJay commented Jul 4, 2017

jeking3 commented Nov 23, 2017

inkychris commented Sep 23, 2022