Make unbind function consistent with key function
#88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `key` function and `unbind` function were assymetrical
so the following ignored the clear meaning intended:
key('a, b', function() { alert("You Hit A or B!") });
# User Interaction...
key.unbind('a, b')
Only `a` was unbound.
The code was almost 100% there; I just mirrored the behavior I saw in
the `assignKeys` function.
The code is tested (failing tests were produced first).
|
I think this is pretty much the same as #97, which was just merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
keyfunction andunbindfunction were assymetricalso the following ignored the clear meaning intended:
Only
awas unbound.The code was almost 100% there; I just mirrored the behavior I saw in
the
assignKeysfunction.The code is tested (failing tests were produced first).