Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harmonized_dossier_visualize() report "missing categorical value" bar plots have only one bar #23

Closed
zchenmr opened this issue Oct 18, 2023 · 2 comments
Labels
enhancement New feature or request to test

Comments

@zchenmr
Copy link

zchenmr commented Oct 18, 2023

The pooled harmonized visual report on the DEMO files, when using a grouping variable, has bar plots of missing categorical values across groups for each variable. This is informative if there are multiple types of missing values (ex: NA, don't know, prefer not to answer) but less so when there is only one type of missing value. In cases where there are only NA values and no other types of missing values, the pie charts below the bar plots provide a better visual representation of the information. Maybe there would be a better way to visualize the count of NA values other than having single bars in a bar plot, or maybe this plot could be removed when NA is the only type of missing value.

image

image

@GuiFabre
Copy link
Contributor

good point 👍

image

@GuiFabre GuiFabre added to test good first issue Good for newcomers enhancement New feature or request and removed good first issue Good for newcomers labels Oct 19, 2023
GuiFabre added a commit to maelstrom-research/madshapR that referenced this issue Oct 19, 2023
@zchenmr
Copy link
Author

zchenmr commented Oct 24, 2023

Seems to be resolved - the bar plot only appears when there are multiple missing value types, otherwise only the pie chart is shown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request to test
Projects
None yet
Development

No branches or pull requests

2 participants