Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use an environment variable to select LLVM version #32

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Use an environment variable to select LLVM version #32

merged 2 commits into from
Jun 9, 2020

Conversation

jmgorius
Copy link
Collaborator

@jmgorius jmgorius commented Jun 9, 2020

This allows the cache to be invalidated automatically when the LLVM commit number changes, without having to manually update the name for each CI update.

@jmgorius
Use an environment variable to select LLVM version
466fcee 
This allows the cache to be invalidated automatically when the LLVM commit number changes, without having to manually update the name for each CI update.
@rodonisi
Copy link
Collaborator

rodonisi commented Jun 9, 2020

Super nice solution, thank you!
I think the new cache key is missing for the docgen job step, otherwise looks good to me!

@jmgorius
Copy link
Collaborator Author

jmgorius commented Jun 9, 2020

Right, should be fixed now.

@rodonisi
Copy link
Collaborator

rodonisi commented Jun 9, 2020

awesome, thank you!

@rodonisi rodonisi merged commit e1a8cf7 into master Jun 9, 2020
@rodonisi rodonisi deleted the ci-select-llvm-commit branch June 9, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodonisi rodonisi Awaiting requested review from rodonisi

@maerhart maerhart Awaiting requested review from maerhart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmgorius @rodonisi