This repository has been archived by the owner on Feb 13, 2024. It is now read-only.
Fix SDK install on Ubuntu 14.04 with future parser #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossg
added a commit
that referenced
this pull request
Jul 23, 2015
Fix SDK install on Ubuntu 14.04 with future parser
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the future parser enabled, an install of the Android SDK on Ubuntu 14.04 will fail due to the attempted installation of the nonexistent package
ia32-libs. This occurs due to missing quotes around the version14.04compared with$::lsbdistreleasethat leads to an equality comparison between incompatible types (see sdk.pp and the future parser documentation).This pull request adds the necessary quotes in two places and also fixes some small lint errors and updates a deprecated Forge remote URL.
Tested on Ubuntu 14.04.2 with Puppet 3.8.1 with future parser enabled and with future parser disabled, and with Puppet 4.2.1.
Related in part to #21.
(This is a critical error for us and blocks our use case for this module.)