Fix title not setting custom error messages; update documentation #13
Conversation
| @@ -165,7 +165,7 @@ export default Ember.Mixin.create({ | |||
| } else { | |||
| parent.addClass('has-error'); | |||
| element.next('.input-error').remove(); | |||
| element.after('<p class="input-error" role="alert">' + errorMessage + '</p>'); | |||
| element.after(`<label class="input-error" role="alert" for="${element.attr("id")}">${errorMessage}</label>`); | |||
There was a problem hiding this comment.
I'm not entirely sure about the label tag here. Isn't this label only to be used on par with an input? That's not really the case here. For the ${} syntax, what's the browser support of it (I think this is ES6 syntax and is converted to ES5 in Ember-CLI right?)
There was a problem hiding this comment.
@bakura10, yes. And since all error messages are for input controls, the label is the safest, most accessible choice. The label is better than any other element because is automatically focuses the corresponding input, select, or textarea element when clicked.
There was a problem hiding this comment.
labels should be used for all form controls: select, textarea, and input elements. The W3c spec will explain more.
|
That looks good! I'm not doign any EmberJS work at the moment, but did you try it with latest version of Ember? Does it still work even in 1.13 with Glimmer? I think that the library could be done better now with the new tools (especially about a more extensible way to render errors... i don't like the fact that people are stuck with the pre-defined markup, either being a or a this lacks flexibility... but at the same time I don't want to have custom input elements, as I like the idea of this library being completely plug and play and not requiring changes to the form code. |
|
@bakura10, I've tested with the latest non-glimmer EmberJS. As in, I have tested on |
|
Are we still merging this? |
|
My mistake. Sure. |
Fix title not setting custom error messages; update documentation
I've updated the addon so that rather than just
<input type="radio" />buttons having error messages customized by theirtitleattributes, all inputs will share this behaviour.I have outlined all of this, and more, in the
readme.mdfile.I have also fixed a number of typos and grammatical errors, as well as provided some useful examples.