Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add traefik plugin for request forwarding #73

Merged
merged 29 commits into from
May 10, 2023
Merged

feat: add traefik plugin for request forwarding #73

merged 29 commits into from
May 10, 2023

Conversation

PatrickMi
Copy link
Contributor

@PatrickMi PatrickMi commented Mar 3, 2023 •
edited
Loading

Resolves #72

@dargmuesli dargmuesli removed their assignment Mar 3, 2023
dargmuesli
dargmuesli requested changes Mar 6, 2023
View reviewed changes
Copy link
Member

@dargmuesli dargmuesli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the submission!
What do you think of adding the CI pipeline and test from https://github.com/traefik/plugindemo?
Please remove the .DS_Store file from this PR.

src/development/plugins-local/src/github.com/PatrickMi/body-forward-auth/.traefik.yml Outdated Show resolved Hide resolved
src/development/plugins-local/src/github.com/PatrickMi/body-forward-auth/.traefik.yml Outdated Show resolved Hide resolved
src/development/plugins-local/src/github.com/PatrickMi/body-forward-auth/.traefik.yml Outdated Show resolved Hide resolved
src/development/plugins-local/src/github.com/PatrickMi/body-forward-auth/body_forward_auth.go Outdated Show resolved Hide resolved
src/development/plugins-local/src/github.com/PatrickMi/body-forward-auth/body_forward_auth.go Outdated Show resolved Hide resolved
src/production/secrets/maevsi/recaptcha-key.secret.template Outdated Show resolved Hide resolved
src/development/stack.yml Outdated Show resolved Hide resolved
src/development/plugins-local/src/github.com/PatrickMi/body-forward-auth/body_forward_auth.go Outdated Show resolved Hide resolved
src/development/stack.yml Outdated Show resolved Hide resolved
src/development/stack.yml Outdated Show resolved Hide resolved
PatrickMi and others added 2 commits March 9, 2023 15:20
@PatrickMi @dargmuesli
Update src/development/plugins-local/src/github.com/PatrickMi/body-fo…
522e105 
…rward-auth/.traefik.yml

Co-authored-by: Jonas Thelemann <e-mail@jonas-thelemann.de>
@PatrickMi
feat(authentication): removes .DS_Store file
dd3c0ab
@PatrickMi
Copy link
Contributor Author

Thank you for the submission!
What do you think of adding the CI pipeline and test from https://github.com/traefik/plugindemo?
Please remove the .DS_Store file from this PR.

Good point. I'll have a look to add the test to our pipeline.
I also deleted the .DS_Store file from the PR

PatrickMi and others added 10 commits March 9, 2023 15:38
@PatrickMi
feat(authentication): removes unused icon path
c44ef37
@PatrickMi
feat(authentication): adds blank lines after code blocks
b3f7190
@PatrickMi
feat(authentication): remove unimportant logging
7c9b4dc
@PatrickMi
feat(authentication): adds constant to enable/disable debug output
e2ee037
@PatrickMi
feat(authentication): removes unimportant logging
b6e2ae3
@PatrickMi @dargmuesli
Update src/development/stack.env.template
875a032 
Co-authored-by: Jonas Thelemann <e-mail@jonas-thelemann.de>
@PatrickMi
feat(authentication): removes todo
da96691
@PatrickMi
feat(authentication): moves plugin and rearrange code
b1cb539 
moves the traefik plugin to the configurations/traefik folder,
moves the instantiation of the httpClient down to where it is used
@PatrickMi
feat(authentication): rename plugin in stack configuration
6968232
@PatrickMi
feat(authentication): uses body-forward-auth plugin from github
f9d96d4
dargmuesli
dargmuesli reviewed Mar 26, 2023
View reviewed changes
src/development/stack.yml Outdated Show resolved Hide resolved
src/development/stack.env.template Outdated Show resolved Hide resolved
@PatrickMi PatrickMi mentioned this pull request Apr 3, 2023
Closed
@dargmuesli dargmuesli linked an issue Apr 3, 2023 that may be closed by this pull request
feat(auth): add a traefik plugin for authentication of form captchas #72
Closed
dargmuesli
dargmuesli approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@dargmuesli dargmuesli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 can be merged when maevsi/maevsi#1122 is ready!

@PatrickMi PatrickMi merged commit 8e2e8b7 into master May 10, 2023
@PatrickMi PatrickMi deleted the traefik_changes branch May 10, 2023 08:55
dargmuesli pushed a commit that referenced this pull request Jun 8, 2023
@PatrickMi @dargmuesli
Revert "Merge pull request #73 from maevsi/traefik_changes"
c5e9bed 
This reverts commit 8e2e8b7.
maevsi-bot pushed a commit that referenced this pull request Jun 8, 2023
@semantic-release-bot
chore(release): 1.7.1 [skip ci]
627bfdc 
## [1.7.1](1.7.0...1.7.1) (2023-06-08)

### Reverts

* Revert "Merge pull request #73 from maevsi/traefik_changes" ([c5e9bed](c5e9bed)), closes [#73](#73)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dargmuesli dargmuesli dargmuesli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(auth): add a traefik plugin for authentication of form captchas
2 participants
@PatrickMi @dargmuesli