Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(recommendation): add enum and tables needed for event recommenda… #53

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

myyxl
Copy link
Contributor

@myyxl myyxl commented Jan 19, 2024

Added the enum and tables required for the event recommendation. Not sure how to implement the tree structure for subcategories.

src/verify/enum_event_category.sql Outdated Show resolved Hide resolved
@myyxl
Copy link
Contributor Author

myyxl commented Jan 25, 2024

What's missing:

  • Invited condition for event mapping policy
  • verify and revert of policies

Is a revert needed if only row level security is enabled and no policy was created?

@dargmuesli dargmuesli marked this pull request as draft January 25, 2024 22:37
@myyxl myyxl marked this pull request as ready for review February 1, 2024 20:37
BEGIN;

CREATE TABLE maevsi.user_interest (
user_id uuid NOT NULL REFERENCES maevsi.account(id) ON DELETE CASCADE,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's call it account_id (it should be called account_id in all other places currently)


BEGIN;

CREATE TYPE maevsi.event_category AS ENUM (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create a table for that, so some administrators can change the list via some content management system in the future without having to change the database code.

Enum type event_category replaced by table of the same name.  Policies modified. Table and column comments added.
File names changed to be in accordance with table name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants