Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(report): add report system #61

Merged
merged 12 commits into from
Oct 13, 2024
Merged

feat(report): add report system #61

merged 12 commits into from
Oct 13, 2024

Conversation

myyxl
Copy link
Contributor

@myyxl myyxl commented Apr 16, 2024

Since we need a report system I added a table for that.

The policies are still missing and will be implemented soon.

Do we need a new role for the report system? Since a normal account shouldn't be able to access the reports, right?

@myyxl myyxl changed the title Feat // Report System feat(report): add report system Apr 16, 2024
@myyxl myyxl self-assigned this Apr 16, 2024
@myyxl myyxl requested a review from dargmuesli April 16, 2024 20:48
@dargmuesli
Copy link
Member

Great question: A normal account should very much be able to access report! For creating reports, that is, and monitoring the status of their reports. A policy defining the creator of a report to be the only one able to access it must be defined of course.

How admins work with reports is another topic. We could set up email notifications or build an admin dashboard. Notifications make more sense for now, I'd say.

@dargmuesli dargmuesli marked this pull request as draft April 16, 2024 21:46
@myyxl
Copy link
Contributor Author

myyxl commented Apr 17, 2024

Notifications are a solution yes, but we still need to manage these reports, right? So we need some kind of interface. Unless we want to manually fiddle with the database.

@dargmuesli
Copy link
Member

Let's fiddle with the database until there are some reports or reports that need to be managed by a non-admin.

@myyxl myyxl marked this pull request as ready for review April 30, 2024 13:55
src/deploy/table_report.sql Outdated Show resolved Hide resolved
src/deploy/table_report_policy.sql Show resolved Hide resolved
src/verify/table_report_policy.sql Show resolved Hide resolved
src/deploy/table_report.sql Outdated Show resolved Hide resolved
Copy link
Member

@dargmuesli dargmuesli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the collaboration! LGTM 💚

@dargmuesli dargmuesli merged commit ae12fac into master Oct 13, 2024
7 checks passed
@dargmuesli dargmuesli deleted the feat/report-system branch October 13, 2024 00:48
@maevsi-bot
Copy link

🎉 This PR is included in version 3.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants