Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for upickle #15

Closed
wants to merge 2 commits into from
Closed

Add support for upickle #15

wants to merge 2 commits into from

Conversation

rleibman
Copy link

Hi Matthew! Hey... I almost got upickle working, but I'm afraid I don't understand string interpolation well enough, somewhere I think it's missing a flatten, some of the tests are not passing. Do you mind taking a look at it, please?

Specifically:

[info] - can inject Option values with implicit Writes *** FAILED ***
[info]   [[1]] did not equal [1] (Test.scala:18)

Thanks!

@maffoo maffoo mentioned this pull request Dec 7, 2019
@maffoo
Copy link
Owner

maffoo commented Dec 7, 2019

Thanks for this, @rleibman. I've made some changes on your branch to get upickle support working, please see #16, and in particular the last commit ae7a6b4.

@maffoo
Copy link
Owner

maffoo commented Dec 8, 2019

Merged as part of #16.

@maffoo maffoo closed this Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants