fix wait to use the correct wait index #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waiting on a key will fail if the wait index is too old. This happens when waiting on a key that does not change a lot but other keys are changing. Previous behavior would fail with an error which the caller would have to handle. This commit internalizes the logic to this module. Alternative approach is to document this error and make etcdjs.wait callers handle it.
|
Technically this is only a "half-assed" solution. The more correct solution per the etcd docs (linked in the code comment) is to call a get after the wait to have a new value but that would maybe require calling the callback that is interested in the wait events in the first place with maybe an artificially created |
|
Talking on twitter just reminded me that I forgot about this issue. I'm fine with this change for now. Could you open an issue that document that we need to do the better solution at some point? |
mafintosh
added a commit
that referenced
this pull request
May 8, 2015
fix wait to use the correct wait index
|
2.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on a key will fail if the wait index is too old. This happens
when waiting on a key that does not change a lot but other keys are
changing. Previous behavior would fail with an error which the caller
would have to handle. This commit internalizes the logic to this module.
Alternative approach is to document this error and make etcdjs.wait
callers handle it.