Lazy run interval #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not run interval on module import, but when we call the function. Some SPA frameworks (like Angular) detect this timer call and run a change detection every 250ms. Now we run the timer only when we call the function, we have a way to say to the framework "execute the speedometer function but don't check the DOM when `setInterval` is fired."
Chocobozzz
added a commit
to Chocobozzz/PeerTube
that referenced
this pull request
Jun 18, 2018
So we don't run Angular change detection every 250ms on webtorrent import, when mafintosh/speedometer#7 will be merged
|
Neat! Published in 1.1.0 |
|
Thanks for you work @mafintosh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not run interval on module import, but when we call the function.
Some SPA frameworks (like Angular) detect this timer call and run a change detection every 250ms. Now we run the timer only when we call the function, we have a way to say to the framework "execute the speedometer function but don't check the DOM when
setIntervalis fired."