Allow the user time-consuming cancel implementations #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lag after function succeeds
corot
requested changes
Feb 14, 2020
corot
approved these changes
Feb 14, 2020
|
lgtm, will test during the weekend |
|
This is fine, logically it just moves the setting of the flag down, which will - as discussed - finish the cancel method first, and if the cancel method is not implemented, the controller execution will cancel the action after it returned from computeVel... |
|
Would this feature be enough to justify a new debian release? 😇 |
|
Sure, I will merge the other two open PR at the weekend and make a new release. ;) cheers. |
|
ping :) |
cxy2020
pushed a commit
to cxy2020/move_base_flex
that referenced
this pull request
Mar 24, 2020
* Allow the plugin developer time-consuming cancel implementations by setting the internal cancel flag after the plugin's cancel method succeeded.
cxy2020
pushed a commit
to cxy2020/move_base_flex
that referenced
this pull request
Mar 24, 2020
* Allow the plugin developer time-consuming cancel implementations by setting the internal cancel flag after the plugin's cancel method succeeded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by setting the flag after function succeeds
Solves #171