Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map Preview freeze when process (ill-formatted) CSIRO Marlin GeoServer WMS URLs #3458

Closed
t83714 opened this issue May 1, 2023 · 1 comment
Closed

Map Preview freeze when process (ill-formatted) CSIRO Marlin GeoServer WMS URLs #3458

t83714 opened this issue May 1, 2023 · 1 comment
Labels
bug
Milestone
v2.2.4

Comments

@t83714
Copy link
Contributor

t83714 commented May 1, 2023

Describe the bug

Map Preview freeze when process (ill-formatted) CSIRO Marlin GeoServer WMS URLs.

https://uprgade-csw-connector.dev.magda.io/api/v0/registry/records/ds-marlin-c3e1e8d0-ea59-4053-b356-f5746ae224ed?optionalAspect=dcat-dataset-strings&optionalAspect=dcat-distribution-strings&optionalAspect=dataset-distributions&optionalAspect=formats&dereference=true

 dcat-distribution-strings: 
{
     		accessURL: "https://www.cmar.csiro.au/geoserver/wms?&CQL_FILTER=SURVEY_NAME%20%3D%20%27KIM197105%27",
     		description: "Hydrology data for Kimbla Voyage KIM 5/71",
     		format: "OGC:WMS-1.3.0-http-get-map",
     		title: "mnf:HYDROLOGY_HEADER_AODN_VIEW"
 },
  • Issue 1: has ?& in the url
  • issue 2: the layer name should be the distribution name

Need to investigate the followings:

  • Why multiple layer dropdown doesn’t show?

Correct URL should be:

https://www.cmar.csiro.au/geoserver/wms?CQL_FILTER=SURVEY_NAME%20%3D%20%27KIM197105%27&service=WMS&version=1.3.0&request=GetCapabilities&layer=mnf:HYDROLOGY_HEADER_AODN_VIEW
@t83714 t83714 added the bug label May 1, 2023
@t83714 t83714 added this to the v2.2.4 milestone May 1, 2023
t83714 added a commit that referenced this issue May 2, 2023
@t83714
#3458: fixed Map Preview freeze when process (ill-formatted) CSIRO Ma…
1bbb919 
…rlin GeoServer WMS URLs
t83714 added a commit that referenced this issue May 3, 2023
@t83714
related to #3458:
eb02f9b 
- only make proxied requests when preview map config allow it
- avoid the unnecessary extra requests
@t83714 t83714 mentioned this issue May 4, 2023
Merged
2 tasks
t83714 added a commit that referenced this issue May 4, 2023
@t83714
related to #3458: bug fix
4ca4333
@t83714 t83714 mentioned this issue May 4, 2023
Merged
3 tasks
@t83714
Copy link
Contributor Author

t83714 commented May 8, 2023

closed via PR: #3459 & magda-io/magda-preview-map#20

@t83714 t83714 closed this as completed May 8, 2023
@t83714 t83714 mentioned this issue Aug 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.2.4
Development

No branches or pull requests
1 participant
@t83714