Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made readOnlyTests in RecordsServiceSpec cover multi-tenant scenarios. #2367

Merged
merged 5 commits into from
Aug 6, 2019
Merged

Made readOnlyTests in RecordsServiceSpec cover multi-tenant scenarios. #2367

merged 5 commits into from
Aug 6, 2019

Conversation

mwu2018
Copy link
Contributor

@mwu2018 mwu2018 commented Jul 22, 2019 •
edited
Loading

What this PR does

Fixes #2354 and #2383
In particular, fixed dereferecing bug and added dereferencing test on system tenant.

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable
  • I've updated CHANGES.md with what I changed.
  • I've linked this PR to an issue in ZenHub (core dev team only)

@AlexGilleran AlexGilleran merged commit 2c86402 into master Aug 6, 2019
@AlexGilleran AlexGilleran deleted the issue/2354 branch August 6, 2019 02:06
@AlexGilleran AlexGilleran mentioned this pull request Aug 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexGilleran AlexGilleran AlexGilleran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make readOnlyTests in RecordServiceSpec test in multi-tenant scenarios
2 participants
@mwu2018 @AlexGilleran