Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React / NodeJs 18 / Typescript / Webpack 5 Upgrade #3501

Merged
merged 111 commits into from
Feb 16, 2024
Merged

React / NodeJs 18 / Typescript / Webpack 5 Upgrade #3501

merged 111 commits into from
Feb 16, 2024

Conversation

t83714
Copy link
Contributor

@t83714 t83714 commented Dec 12, 2023 •
edited
Loading

What this PR does

Fixes:

  • React 18 Upgrade & NodeJs Upgrade #3484
  • Upgrade to Node 18 #3472
  • React 18 Upgrade & NodeJs Upgrade #3484
  • replace ts-node with tsx
  • replace nyc with c8
  • web worker handling re-written
  • Upgraded to typescript 5 & webpack 5
  • Move away from the pancake #3486: Removed @gov.au/pancake from dependencies
  • re-written frontend web worker handling
  • fixed: when the supplied API key is not found, 401 code will be responded rather than 500
  • adjusted CI pipeline workflow
  • replaced isomorphic-fetch with cross-fetch
  • replaced request lib usage (including registry client libs) with cross-fetch or node-fetch
  • removed request function export from @magda/utils & @magda/typescript-common
  • reduced the size of magda-scss-compiler docker image
  • upgraded http-proxy, pg & other dependencies

Checklist

  • There are unit tests to verify my changes are correct
  • I've updated CHANGES.md with what I changed.

@t83714
remove pancake dependencies
37903d3
@t83714
adjust dependencies
2a2a40b
@t83714
avoid loading core.scss without loading variables.scss
5dd6d5f
@t83714
dependencies adjustments & type / code refactoring
7511903
@t83714
more types adjustments
1e06bd1
@t83714
update docker image to use node 18 version
a31ca76
@t83714
update docker image version used in CI pipeline
725653b
@t83714
reset cache
0c60916
@t83714
fixes CI pipeline
91280bb
@t83714
print out env
7a90e37
@t83714
set path manually for all sbt docker image usage in CI
ffab97b
@t83714
new way of setting env vars
d776e26
@t83714
fixed .profile
df8ed99
@t83714
escape $ in profile
bf7692d
@t83714
fixes eslint calling errors
4d3d61d
@t83714
remove PATH var settings
5e3c3bd
@t83714
fix storage api
38166de
@t83714
replace isomorphic-fetch with cross-fetch
dba8440
@t83714
fix scss compiler build issue
dc680b9
@t83714
upgrade bcrypt and upgrade node to 18 for auth api
b85105f
@t83714
upgrade all docker container to node18
28a50dc
@t83714
upgrade nock to 13.4.0
922cafc
@t83714
update yarn.lock
d115bc8
@t83714
fixed build error
e205cbd
@t83714
fixed auth api type errors
2e8d995
@t83714
upgrade supertest & superagent to latest version
60297b2
@t83714
- upgrade express & express-session related package
9511421 
- fixes test cases for gateway
- CookieOptions.secure is now a boolean type (to be consistent with express-session). 'auto' string value is no longer support
@t83714
- upgrade nyc & mocha to v10
698f3fd 
- rewrite opaRouter with node-fetch
- convert magda-typescript-common to esm module
@t83714
- make auth-api build & test
b5b5a42 
- replace ts-node with tsx
@t83714
remove unused resolvePkg
a75f322
@t83714
upgrade & fixed react-select
9fde598
@t83714
fixed minion framework build issue
a6c233b
@t83714
- fixed react-select type issue
6ded895 
- correct getUserApiKeyById error message
@t83714
incorrect API key id should trigger 401 rather than 500 error
d73f4c1
@t83714
fix worker processing & keyword processing
3a12cbe
@t83714
auto clean up files during scss-compiler docker image building
e0956bb
@t83714
only clean up web client module
757e9de
@t83714
fixed css resolve issue
7df1bf0
@t83714
- adjust scss-compiler file cleanup
8729bbf 
- remove magda-web-server `devProxy`
- replace request lib usage with node-fetch
@t83714
- remove "request" function from typescript-common
087cfd1 
- remove "request" function from @magda/utils
- clean up remove "request" from other modules
@t83714
fixed status test case
6a26b3d
@t83714
- replace request lib usage with cross-fetch
ec15b0b 
- remove unused `pkg` dependency
@t83714
registry api client code auto-generation fixes
623ce0e
@t83714
fixed error with correspondence-api
3acf0d7
@t83714
registry api client code auto generation bug fix
f48eee8
@t83714
- fixed node-fetch should be dep of correspondence-api
c2d0bcc 
- scss-compiler cleanUp code should skip package.json
@t83714
fix: ignore string to skip magda-web-client package.json
eddfa31
@t83714
adjust scss file resolve logic
455abf1
@t83714
let webpack auto decide asset public path to avoid web worker script …
9ba74b7 
…loading error
@t83714
use forked version of http-proxy
127e8c8
@t83714
upgrade pg to 8.11.3
c1cc370
@t83714
updated changes.md
ced2f5f
@t83714
fixed retag-and-push script incorrect import
ff8aeb3
This was referenced Feb 11, 2024
Closed
Closed
Closed
Closed
@t83714 t83714 added this to the v2.3.4 milestone Feb 16, 2024
@t83714 t83714 merged commit 2e90219 into main Feb 16, 2024
4 checks passed
@t83714 t83714 deleted the react-18 branch February 16, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@t83714