Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors after running Run Client #6395

Closed
drowinternet opened this issue Apr 5, 2020 · 4 comments
Closed

Errors after running Run Client #6395

drowinternet opened this issue Apr 5, 2020 · 4 comments

Comments

@drowinternet
Copy link
Contributor

The client doesn't seem to launch and I get 42 errors. I'm using VSC. The error are all from the New Features Dialog in Mage.client...\client\dialog and include:

The import javafx cannot be resolved
JFXPanel cannot be resolved to type
Webview cannot be resolved to type

ect

I've also tried Run Client in IntelliJ and the terminal seems to hang when it tries to load symbols. VSC seems to be able to load symbols but stops at:

at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

I'm trying to implement card from Ikoria but don't want to do a pull request without testing first.

Thank you,

@Elandril
Copy link
Contributor

Are you by any change using OpenJDK? JavaFX is not part of OpenJDK as it was split into a separate project (OpenJFX) some years back. Therefore OpenJDK 8 to 13 do not offer it, but for 14 they are considering/working on re-integrating it.

You need to use the Oracle JDK 1.8 to get JavaFX support, as there are no versions for OpenJDK. There are two alternative JDKs that I know of that bundle JavaFX 8: Azul Zulu and BellSoft Liberica, but I have not tested either of these.

There are some details about this in the OpenJDK FAQs and some people who manually added the JavaFX jar, but I would not recommend that course of action.

@JayDi85
Copy link
Member

JayDi85 commented Apr 16, 2020

Client must works fine without JavaFX on system (e.g. with OpenJDK). It's can be another problem like:

  1. Auto-login freeze (fix);
  2. Broken symbols files (fix: delete \xmage\mage-client\plugins\images\symbols folder and restart client).
  3. You are run client under default system java (xmage works with Java 8 only, fix: choose java version in IDE);

@allentiak
Copy link
Contributor

The client cannot be built without JavaFX. The WhatsNew class uses it.
See #6197.

@Zerrisx
Copy link

Zerrisx commented Jul 15, 2020

I'm pretty sure this is a straight duplicate of #6197.

@Zerrisx Zerrisx closed this as completed Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants