Comply with Adobe Legal #43
Conversation
adifucan
commented
Jan 31, 2020
adifucan
commented
- Add license;
- Add code of conduct;
- Add contribution guidelines;
- Add copyright header;
- Add license; - Add code of conduct; - Add contribution guidelines; - Add copyright header;
|
@filmaj does Adobe have an existing package we can use in CI to validate new files have the licensing requirements going forward? I have an adhoc script, but something maintained might be better if it exists |
|
We do not maintain something like that but there are existing tools out there: Apache RAT for Apache-2.0 licensed projects is a common one, and depending on your language, usually there are lint plugins available for ensuring copyright header are present. For JS: |
|
|
||
| For more detailed information on contribution please read our [beginners guide](https://github.com/magento/magento2/wiki/Getting-Started). | ||
|
|
||
| ## Contribution requirements |
There was a problem hiding this comment.
We should change these contribution requirements, since we're not enforcing quite a few of the standards required in Magento core.
Some notes:
- Docs go in this repo, rather than devdocs (want them versioned together with code)
- We don't require following Magento coding standards
There was a problem hiding this comment.
Contribution requirements updated.
- Update contribution guidelines;
|
Opened #46 to track automation of license check |
|
Thanks for the speedy resolution here y'all <3 |
