Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL Checkout :: Add support for Gift Wrapping / Gift Message during checkout. #28519

Closed
nrkapoor opened this issue Apr 9, 2020 · 6 comments · Fixed by #27956, #28105 or #28072
Closed
Assignees
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Partner: Atwix Pull Request is created by partner Atwix Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Project: GraphQL Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Milestone

Comments

@nrkapoor
Copy link

nrkapoor commented Apr 9, 2020

As a Magento Merchant,
I would like the ability to offer my customers gift wrapping and gift messaging options during checkout 
so that 
they can send the products purchased from my business as a gift to their friends/families etc. 

 

Acceptance Criteria
GraphQL provides all available gift options for a store.  
GraphQL provides the option to select the gift option for each line item 
GraphQL provides the option to add a gift message for the entire cart and for each item in the cart.

Approved Schema

@nrkapoor nrkapoor assigned nrkapoor and rogyar and unassigned nrkapoor Apr 9, 2020
@okorshenko okorshenko transferred this issue from magento/community-features Jun 4, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 4, 2020

Hi @nrkapoor. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


@ghost ghost added this to Ready for QA in Community Backlog Jun 4, 2020
@okorshenko okorshenko moved this from Ready for QA to Ready for Dev in Community Backlog Jun 4, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 4, 2020

Hi @eduard13. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@ghost ghost moved this from Ready for Dev to Dev in Progress in Community Backlog Jun 4, 2020
@nrkapoor nrkapoor added this to the 2.4.1 milestone Jun 4, 2020
@eduard13 eduard13 assigned Usik2203 and unassigned eduard13 Jun 5, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 5, 2020

Hi @Usik2203. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
      DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
    1. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Jun 5, 2020
@nrkapoor nrkapoor moved this from Dev in Progress to PR In Progress in Community Backlog Jun 5, 2020
@nrkapoor nrkapoor linked a pull request Jun 5, 2020 that will close this issue
@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog Jun 5, 2020
@lenaorobei lenaorobei reopened this Jun 5, 2020
@ghost ghost assigned Usik2203 and unassigned Usik2203 Jun 5, 2020
@ghost ghost moved this from Done (last 30 days) to PR In Progress in Community Backlog Jun 5, 2020
@lenaorobei lenaorobei removed the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Jun 5, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Jun 5, 2020
@lenaorobei
Copy link
Contributor

Internal Jira ticket MC-32345.

@nrkapoor nrkapoor added Partner: Atwix Pull Request is created by partner Atwix Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Jun 9, 2020
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jun 23, 2020
@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog Jun 23, 2020
@mikhaelbois
Copy link

mikhaelbois commented Sep 30, 2021

Hello,

#28072 enables users to add a Gift Message to each Order Item.
But it doesn't seem to let users add a Gift Message at the entire Order Level.

To do this, we would need to use the setGiftOptionsOnCart mutation which is only available on Adobe Commerce.

Would it be possible to move the Gift Message part from that mutation to the GiftMessageGraphQl module which is Open Source?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Partner: Atwix Pull Request is created by partner Atwix Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Project: GraphQL Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
No open projects
Community Backlog
  
Done (last 30 days)
8 participants