Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphQl] Gift Message coverage for cart item #28072

Merged

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented May 1, 2020

Description (*)

This PR extends PR #27956 (Parent PR)
add coverage for cart items,
add mutation for updating gift message of cart items
add parameters to StoreConfig

This PR was mentioned for fixing failed Integration test
#259
#251
#246

Fixed Issues (if relevant)

  1. Fixes GraphQL Checkout :: Add support for Gift Wrapping / Gift Message during checkout. #28519 GraphQL Checkout :: Add support for Gift Wrapping / Gift Message during checkout.

Related Pull Requests

https://github.com/magento/partners-magento2-infrastructure/pull/3

Manual testing scenarios (*)

You can use this query for manual testing. You should take maskedQuoteId from quote_id_mask table
.. on SimpleCartItem
.. on ConfigurableCartItem
.. on BundleCartItem

{
    cart(cart_id: "maskedQuoteId") {
      items {
        product {
           name
        }
        ... on SimpleCartItem {
          gift_message {
            to
            from
            message
          }
        }
      }
    }
  }

Mutation for updating gift messages for cart items

mutation {
  updateCartItems(
    input: {
      cart_id: "Bw39gy3HyflLoJapHawMOnTHCOmean44",
      cart_items: [
        {
         cart_item_id: 48
          quantity: 3
         gift_message: {
            to: "Alex"
            from: "Aline"
            message: "Best regards"
          }
        }
      ]
    }
  ) {
    cart {
      items {
        id
        product {
         name
        }
        quantity
          ... on SimpleCartItem {
          gift_message {
            to
            from
            message
          }
        }
     }
    }
  }
}

@m2-assistant
Copy link

m2-assistant bot commented May 1, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard May 1, 2020
@magento-engcom-team magento-engcom-team added Component: GiftMessageGraphQl Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels May 1, 2020
@rogyar rogyar self-assigned this May 3, 2020
@rogyar rogyar self-requested a review May 4, 2020 11:32
@rogyar rogyar changed the title [WIP] GiftMessageGraphQl coverage for cart item [WIP][GraphQl] Gift message attribute coverage for cart item May 4, 2020
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Usik2203. Thank you for your collaboration. Please, check my comments below and feel free to proceed with the test coverage afterward.

Thank you!

@ghost ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard May 4, 2020
@rogyar rogyar added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label May 4, 2020
@Usik2203 Usik2203 force-pushed the graphql-256-cart-item-coverage branch from c6d6923 to e915b4e Compare May 5, 2020 16:31
@rogyar rogyar self-requested a review May 7, 2020 13:25
@Usik2203 Usik2203 force-pushed the graphql-256-cart-item-coverage branch 3 times, most recently from 2a59426 to 514891a Compare May 12, 2020 08:21
@Usik2203 Usik2203 marked this pull request as draft May 12, 2020 15:22
@rogyar rogyar self-requested a review May 13, 2020 08:28
@rogyar rogyar marked this pull request as ready for review May 13, 2020 08:40
@rogyar rogyar removed the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label May 13, 2020
@Usik2203
Copy link
Contributor Author

@magento run all tests

@ghost ghost moved this from Merge in Progress to Ready for Testing in Pull Requests Dashboard Jun 20, 2020
@rogyar rogyar moved this from Ready for Testing to Merge in Progress in Pull Requests Dashboard Jun 20, 2020
@ghost ghost moved this from Merge in Progress to Ready for Testing in Pull Requests Dashboard Jun 20, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7559 has been created to process this Pull Request

@m2-assistant
Copy link

m2-assistant bot commented Jun 23, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: advanced Award: category of expertise Award: special achievement Award: test coverage Component: GiftMessageGraphQl Component: QuoteGraphQl Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Project: GraphQL QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Pull Requests Dashboard
  
Recently Merged
Development

Successfully merging this pull request may close these issues.

GraphQL Checkout :: Add support for Gift Wrapping / Gift Message during checkout.