GraphQL-432: Test coverage: 'reversed quote id to masked cart id' #449
Conversation
… and replaced method in one api-functional test
| use Magento\Quote\Model\QuoteIdToMaskedQuoteIdInterface; | ||
| use Magento\Quote\Model\QuoteFactory; | ||
|
|
||
| class GetMaskedQuoteIdByReversedQuoteId |
There was a problem hiding this comment.
Please, reuse this class in all of the places (find by getMaskedQuoteIdByReversedQuoteId)
But not just in one testcase class
Also, this class is used just for testing, so need to move to test directory dev/tests/api-functional/testsuite/Magento/GraphQl/Quote
``
There was a problem hiding this comment.
@naydav , I am sorry but I have a question about GetMaskedQuoteIdByReversedQuoteId class name.
We load quote by reserved_order_id field
$this->quoteResource->load($quote, $reversedQuoteId, 'reserved_order_id');
and in the same time new class is called as GetMaskedQuoteIdByReversedQuoteId.
May we should use a proper name for it - GetMaskedQuoteIdByReservedOrderId?
Thank you!
CC: @AleksLi
There was a problem hiding this comment.
Hi @atwixfirster,
I saw the fix in your PR https://github.com/magento/graphql-ce/pull/450/files
But for avoiding a lot of merge conflicts I am going to merge all of related PRs and finally make the fix in your PR which will be merged last.
There was a problem hiding this comment.
I didn't cover everything in all the places, because I thought it might be something with the class name or so. I will do that now
…. Added new class to handle that.
…uote-id-test-coverage # Conflicts: # dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/GetAvailablePaymentMethodsTest.php # dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/GetCartTest.php # dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/SetShippingAddressOnCartTest.php # dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/GetAvailablePaymentMethodsTest.php
|
Hi @AleksLi, thank you for your contribution! |
Description (*)
Created separate class GetMaskedQuoteIdByReversedQuoteId and replaced method in one api-functional test.
Fixed Issues (if relevant)
Manual testing scenarios (*)
\Magento\GraphQl\Quote\SetShippingAddressOnCartTestclass