Web api of stock source links management #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
maghamed
approved these changes
Sep 8, 2017
| @@ -14,7 +14,8 @@ | |||
| </resource> | |||
| <resource id="Magento_InventoryApi::stock" title="Inventory Stocks" translate="title" sortOrder="20"> | |||
| <resource id="Magento_InventoryApi::stock_edit" title="Edit Inventory Stocks" translate="title" sortOrder="10" /> | |||
| <resource id="Magento_InventoryApi::source_delete" title="Delete Inventory Stocks" translate="title" sortOrder="20" /> | |||
| <resource id="Magento_InventoryApi::stock_delete" title="Delete Inventory Stocks" translate="title" sortOrder="20" /> | |||
There was a problem hiding this comment.
why do we introduce independent resource for Stock Edit and Stock Delete?
why not to have the single ACL resource for both operations?
Like this one:
<resource id="Magento_InventoryApi::stock" title="Manage Inventory Stocks" translate="title" sortOrder="20" />And the same for Source
There was a problem hiding this comment.
Separate ticket has been created
https://github.com/magento-engcom/magento2/issues/89
need to discuss several things in a scope of ACL refactoring
Closed
|
Internal buid https://bamboo.corp.magento.com/browse/M2-AT2506-2 |
|
@naydav https://bamboo.corp.magento.com/ is magento internal domain :( |
sidolov
pushed a commit
that referenced
this pull request
May 11, 2021
MC-34856: PHP 7.4 support for 2.3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/magento-engcom/magento2/issues/83