-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAGECLOUD-3978: [Spike][Cloud Docker] DB data should persist in a volume #92
Conversation
Pros:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it! LGTM
NIT: Could .docker/mysql/docker-entrypoint-initdb.d
be mounted ro
?
As mentioned in the closed PR usually we use This works fine for my developers workflow so I think all we need here is better documentation between down and stop. |
Thanks for the review! Moved to QA |
QA approved |
Description
Fixed Issues (if relevant)
https://magento2.atlassian.net/browse/MAGECLOUD-3978
Manual testing scenarios
docker-compose down
docker-compose up -d
https://jira.corp.magento.com/browse/MAGECLOUD-70
Contribution checklist