-
Notifications
You must be signed in to change notification settings - Fork 27
EQPS-260: Open Source Readiness #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
roribio
commented
Sep 20, 2019
- Add the OSL-3 license as a LICENSE file in the root of the repo.
- Add Magento's code of conduct as a CODE_OF_CONDUCT.md file to the repo.
- All source code (other than machine generated code) should have an OSL-compatible source code header.
- Add contribution guidelines for first-timers as a CONTRIBUTING.md file to the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
The only thing I would recommend is that you and your team review the contribution guidelines and make sure it matches your expectations (I left a few comments inline there). You should assume that new contributors will read through that document and follow it exactly. So it is in your best interest to have it contain as much info as possible to help contributors get their changes accepted / meets your team's and this project's expectations.
CONTRIBUTING.md
Outdated
@@ -0,0 +1,36 @@ | |||
# Contributing to Magento 2 code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this file is only a template. I think it should be customized a little to meet this project's specifics requirements, while maintaining the core requirements across all Magento projects. I'll drop some more comments below...
@filmaj Thanks for the awesome feedback, Fil! I've gone through and addressed all of your suggestions. I've aslo submitted a request to add this repo to the CLA tool. Thanks! |
Great, cheers! |
BTW as a heads up, on Oct 1 we will be switching all magento repos over from the old Magento CLA tool to the new Adobe CLA bot + document. The new CLA is up on https://opensource.adobe.com/cla.html. FYI, in case you want to update the contribution guidelines to point to the new CLA now; this can also be done later after we roll out the new bot. Up to you. |
Awesome, thanks for the heads up! Might as well do it now 💥 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a tiny suggestion but LGTM otherwise!
Co-Authored-By: Fil Maj <maj.fil@gmail.com>
MQE-2305: Implement `-report-type=mftf` in magento-semver to launch MFTF SVC
[Arrows] MC-36802: SVC doesn't catch MINOR change in PATCH release when adding @api to a class