Skip to content

Conversation

roribio
Copy link
Contributor

@roribio roribio commented Sep 20, 2019

  • Add the OSL-3 license as a LICENSE file in the root of the repo.
  • Add Magento's code of conduct as a CODE_OF_CONDUCT.md file to the repo.
  • All source code (other than machine generated code) should have an OSL-compatible source code header.
  • Add contribution guidelines for first-timers as a CONTRIBUTING.md file to the repo.

Copy link

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

The only thing I would recommend is that you and your team review the contribution guidelines and make sure it matches your expectations (I left a few comments inline there). You should assume that new contributors will read through that document and follow it exactly. So it is in your best interest to have it contain as much info as possible to help contributors get their changes accepted / meets your team's and this project's expectations.

CONTRIBUTING.md Outdated
@@ -0,0 +1,36 @@
# Contributing to Magento 2 code
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this file is only a template. I think it should be customized a little to meet this project's specifics requirements, while maintaining the core requirements across all Magento projects. I'll drop some more comments below...

@roribio roribio requested a review from filmaj September 27, 2019 13:16
@roribio
Copy link
Contributor Author

roribio commented Sep 27, 2019

@filmaj Thanks for the awesome feedback, Fil!

I've gone through and addressed all of your suggestions.

I've aslo submitted a request to add this repo to the CLA tool.

Thanks!

@filmaj
Copy link

filmaj commented Sep 27, 2019

Great, cheers!

@filmaj
Copy link

filmaj commented Sep 27, 2019

BTW as a heads up, on Oct 1 we will be switching all magento repos over from the old Magento CLA tool to the new Adobe CLA bot + document. The new CLA is up on https://opensource.adobe.com/cla.html.

FYI, in case you want to update the contribution guidelines to point to the new CLA now; this can also be done later after we roll out the new bot. Up to you.

@roribio
Copy link
Contributor Author

roribio commented Sep 27, 2019

Awesome, thanks for the heads up! Might as well do it now 💥

@roribio roribio requested a review from filmaj September 27, 2019 15:34
Copy link

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a tiny suggestion but LGTM otherwise!

Co-Authored-By: Fil Maj <maj.fil@gmail.com>
@roribio roribio merged commit c94c35b into master Sep 27, 2019
@roribio roribio deleted the roribio/EQPS-260 branch September 27, 2019 15:43
mmansoor-magento pushed a commit that referenced this pull request Oct 21, 2020
MQE-2305: Implement `-report-type=mftf` in magento-semver to launch MFTF SVC
magento-cicd2 pushed a commit that referenced this pull request Feb 24, 2021
[Arrows] MC-36802: SVC doesn't catch MINOR change in PATCH release when adding @api to a class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants