ENGCOM-7222: Issue 27358 #27359

magento · May 14, 2020 · 16dd439 · 16dd439
2 parents e2dd73c + 82d8659
commit 16dd439
Show file tree

Hide file tree

Showing 5 changed files with 56 additions and 2 deletions.
diff --git a/...ch/Test/Mftf/ActionGroup/StorefrontAssertUnableSearchNegativeForPriceFieldActionGroup.xml b/...ch/Test/Mftf/ActionGroup/StorefrontAssertUnableSearchNegativeForPriceFieldActionGroup.xml
@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ /**
+  * Copyright © Magento, Inc. All rights reserved.
+  * See COPYING.txt for license details.
+  */
+-->
+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="StorefrontAssertUnableSearchNegativeForPriceFieldActionGroup" extends="StorefrontFillFormAdvancedSearchActionGroup">
+        <remove keyForRemoval="waitForPageLoad" />
+        <grabTextFrom selector="{{StorefrontCatalogSearchAdvancedFormSection.PriceFromError}}" stepKey="grabPriceFromError"/>
+        <grabTextFrom selector="{{StorefrontCatalogSearchAdvancedFormSection.PriceToError}}" stepKey="grabPriceToError"/>
+        <assertEquals stepKey="assertErrorMessagePriceFrom">
+            <actualResult type="string">{{UnableNegativePrice.Error_message}}</actualResult>
+            <expectedResult type="string">$grabPriceFromError</expectedResult>
+        </assertEquals>
+        <assertEquals stepKey="assertErrorMessagePriceTo">
+            <actualResult type="string">{{UnableNegativePrice.Error_message}}</actualResult>
+            <expectedResult type="string">$grabPriceToError</expectedResult>
+        </assertEquals>
+    </actionGroup>
+</actionGroups>
diff --git a/.../Mftf/Data/MinMaxQueryLengthHintsData.xml → ...rch/Test/Mftf/Data/MessageAndHintData.xml b/.../Mftf/Data/MinMaxQueryLengthHintsData.xml → ...rch/Test/Mftf/Data/MessageAndHintData.xml
@@ -11,4 +11,7 @@
     <entity name="MinMaxQueryLength" type="constant">
         <data key="Hint">This value must be compatible with the corresponding setting in the configured search engine</data>
     </entity>
+    <entity name="UnableNegativePrice" type="constant">
+        <data key="Error_message">Please enter a number 0 or greater in this field.</data>
+    </entity>
 </entities>
diff --git a/...de/Magento/CatalogSearch/Test/Mftf/Section/StorefrontCatalogSearchAdvancedFormSection.xml b/...de/Magento/CatalogSearch/Test/Mftf/Section/StorefrontCatalogSearchAdvancedFormSection.xml
@@ -16,6 +16,8 @@
         <element name="ShortDescription" type="input" selector="#short_description"/>
         <element name="PriceFrom" type="input" selector="#price"/>
         <element name="PriceTo" type="input" selector="#price_to"/>
+        <element name="PriceFromError" type="text" selector="#price-error"/>
+        <element name="PriceToError" type="text" selector="#price_to-error"/>
         <element name="AttributeByCode" type="input" selector="#{{var1}}" parameterized="true"/>
         <element name="SubmitButton" type="button" selector="//*[@id='form-validate']//button[@type='submit']"/>
     </section>

diff --git a/...CatalogSearch/Test/Mftf/Test/StorefrontCheckUnableAdvancedSearchWithNegativePriceTest.xml b/...CatalogSearch/Test/Mftf/Test/StorefrontCheckUnableAdvancedSearchWithNegativePriceTest.xml
@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ /**
+  * Copyright © Magento, Inc. All rights reserved.
+  * See COPYING.txt for license details.
+  */
+-->
+
+<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+       xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
+    <test name="StorefrontCheckUnableAdvancedSearchWithNegativePriceTest">
+        <annotations>
+            <stories value="Use Advanced Search"/>
+            <title value="Unable negative price use to advanced search"/>
+            <description value="Check unable negative price use to advanced search by price from and price to"/>
+        </annotations>
+        <actionGroup ref="StorefrontOpenHomePageActionGroup" stepKey="goToStorefront"/>
+        <actionGroup ref="StorefrontOpenAdvancedSearchActionGroup" stepKey="openAdvancedSearch"/>
+        <actionGroup ref="StorefrontAssertUnableSearchNegativeForPriceFieldActionGroup" stepKey="assertUnableSearch">
+            <argument name="price_to" value="-50"/>
+            <argument name="price_from" value="-10"/>
+        </actionGroup>
+    </test>
+</tests>
diff --git a/app/code/Magento/CatalogSearch/view/frontend/templates/advanced/form.phtml b/app/code/Magento/CatalogSearch/view/frontend/templates/advanced/form.phtml
@@ -5,6 +5,7 @@
  */
 
 // phpcs:disable Magento2.Templates.ThisInTemplate.FoundThis
+// @codingStandardsIgnoreFile
 ?>
 <?php
 /**
@@ -68,7 +69,7 @@
                                    class="input-text"
                                    type="text"
                                    maxlength="<?= $block->escapeHtmlAttr($maxQueryLength) ?>"
-                                   data-validate="{number:true, 'less-than-equals-to':'#<?= $block->escapeHtmlAttr($_code) ?>_to'}" />
+                                   data-validate="{number:true, 'validate-not-negative-number':true, 'less-than-equals-to':'#<?= $block->escapeHtmlAttr($_code) ?>_to'}" />
                         </div>
                     </div>
                     <div class="field with-addon no-label">
@@ -81,7 +82,7 @@
                                        class="input-text"
                                        type="text"
                                        maxlength="<?= $block->escapeHtmlAttr($maxQueryLength) ?>"
-                                       data-validate="{number:true, 'greater-than-equals-to':'#<?= $block->escapeHtmlAttr($_code) ?>'}" />
+                                       data-validate="{number:true, 'validate-not-negative-number':true, 'greater-than-equals-to':'#<?= $block->escapeHtmlAttr($_code) ?>'}" />
                                 <label class="addafter"
                                        for="<?= $block->escapeHtmlAttr($_code) ?>_to">
                                     <?= $block->escapeHtml($block->getCurrency($_attribute)) ?>