Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 27358 #27359

Merged
merged 6 commits into from
May 15, 2020
Merged

Issue 27358 #27359

merged 6 commits into from
May 15, 2020

Conversation

RHapani
Copy link

@RHapani RHapani commented Mar 19, 2020 •
edited by sdzhepa
Loading

Description (*)

The fixed issue of the Advance search page allow minus price filter.

Steps to reproduce (*)

  1. Go to the Advance search page.
  2. Add minus value in price filter and search.

Expected result (*)

It should not allow minus value in price filter.

Actual result (*)

It allows the minus value in price filter.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Advance search page allow minus price filter #27358: Advance search page allow minus price filter

Manual testing scenarios (*)

  1. Go to the Advance search page.
  2. Add minus value in price filter and search.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 19, 2020

Hi @RHapani. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@RHapani RHapani requested a review from diazwatson March 19, 2020 13:45
diazwatson
diazwatson requested changes Mar 20, 2020
View reviewed changes
app/code/Magento/Catalog/Model/Category/Attribute/Backend/Image.php Outdated
@@ -196,8 +196,9 @@ private function fileResidesOutsideCategoryDir($value)
if (!$baseMediaDir) {
return false;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RHapani I don't think this change is necessary, could you please revert it?

@ghost ghost assigned diazwatson Mar 20, 2020
@magento-engcom-team magento-engcom-team added this to Changes Requested in Pull Requests Dashboard Mar 24, 2020
@RHapani
Copy link
Author

RHapani commented Mar 30, 2020

@diazwatson I have updated the changes as per request.

@ghost ghost moved this from Changes Requested to Ready for Testing in Pull Requests Dashboard Mar 30, 2020
@magento-engcom-team
Copy link
Contributor

Hi @diazwatson, thank you for the review.
ENGCOM-7222 has been created to process this Pull Request
✳️ @diazwatson, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@RHapani
Copy link
Author

RHapani commented Apr 2, 2020

@magento-engcom-team It seems like the testing process on hold. Still, the testing process on same position.

@engcom-Alfa engcom-Alfa self-assigned this Apr 6, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Apr 6, 2020
@engcom-Alfa engcom-Alfa added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Apr 6, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
Screenshot from 2020-04-06 10-40-59

After:
screenshotsearch

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Apr 6, 2020
@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo engcom-Echo self-assigned this Apr 8, 2020
@engcom-Echo
Copy link
Contributor

Failed functional tests not related to the changes in this PR

@engcom-Echo engcom-Echo added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Apr 9, 2020
@engcom-Echo engcom-Echo moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Apr 9, 2020
@VladimirZaets VladimirZaets added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Apr 9, 2020
@VladimirZaets VladimirZaets added this to the 2.4.1 milestone Apr 9, 2020
@ghost ghost added the Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. label Apr 30, 2020
@magento-engcom-team magento-engcom-team added Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner labels Apr 30, 2020
@VladimirZaets VladimirZaets removed the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label May 11, 2020
@sdzhepa sdzhepa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label May 14, 2020
@magento-engcom-team magento-engcom-team mentioned this pull request May 15, 2020
Closed
slavvka added a commit that referenced this pull request May 15, 2020
@slavvka
ENGCOM-7222: Issue 27358 #27359
16dd439
@slavvka slavvka merged commit 82d8659 into magento:2.4-develop May 15, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 15, 2020

Hi @RHapani, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard May 15, 2020
@magento-engcom-team magento-engcom-team removed this from Recently Merged in Pull Requests Dashboard May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diazwatson diazwatson Awaiting requested review from diazwatson

Assignees

@diazwatson diazwatson

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: CatalogSearch Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

Advance search page allow minus price filter
9 participants
@RHapani @magento-engcom-team @engcom-Alfa @engcom-Echo @diazwatson @sdzhepa @VladimirZaets @slavvka @engcom-Kilo