Skip to content

Commit

Permalink
#28569: Multi-store: Missing store codes in relation to a group and w…
Browse files Browse the repository at this point in the history
…ebsite

- Fixed static code checks and web api tests
  • Loading branch information
gallyamov committed Jul 1, 2020
1 parent 48749bc commit 362b81a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ public function __construct(ResourceConnection $resource)
}

/**
* Get store by website id
*
* @param int $websiteId
* @return array
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ protected function setUp(): void

/**
* @magentoApiDataFixture Magento/Store/_files/store.php
* @magentoConfigFixture default_store store/information/name Default Store
* @throws NoSuchEntityException
*/
public function testGetStoreConfig(): void
Expand Down Expand Up @@ -109,10 +108,6 @@ private function validateStoreConfig($storeConfig, $responseConfig): void
$this->assertEquals($storeConfig->getSecureBaseLinkUrl(), $responseConfig['secure_base_link_url']);
$this->assertEquals($storeConfig->getSecureBaseStaticUrl(), $responseConfig['secure_base_static_url']);
$this->assertEquals($storeConfig->getSecureBaseMediaUrl(), $responseConfig['secure_base_media_url']);
$this->assertEquals($scopeConfig->getValue(
'store/information/name',
ScopeInterface::SCOPE_STORE,
$storeConfig->getId()
), $responseConfig['store_name']);
$this->assertEquals($storeConfig->getName(), $responseConfig['store_name']);
}
}

0 comments on commit 362b81a

Please sign in to comment.