Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-store: Missing store codes in relation to a group and website #28569

Closed
magento-engcom-team opened this issue Jun 5, 2020 · 10 comments · Fixed by #28794
Closed

Multi-store: Missing store codes in relation to a group and website #28569

magento-engcom-team opened this issue Jun 5, 2020 · 10 comments · Fixed by #28794
Assignees
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed PAP Partners acceleration program Project: GraphQL Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Milestone

Comments

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jun 5, 2020

In order to switch stores in a Multi-store Magento instance, a developer would need a GraphQL Query that would return a list with the following data (currently available for the current store inside storeConfig)

 

query {
  storeConfig {
1. Available
    id 
    header*logo*src 
    logo_alt 
    logo_width 
    logo_height 
    store_name
    ...

1. Missing
    stores {
       id 
       header*logo*src 
       logo_alt 
       logo_width 
       logo_height 
       store_name
       ...
    }
 
  }
}

 

!image-2020-05-11-10-11-04-038.png!

Requirements:

  1. This should be implemented in accordance with architectural proposal Add query to get available stores architecture#390
  2. availableStores query should only return other stores under the same website as the current store. It should not expose other websites.

 

@m2-assistant
Copy link

m2-assistant bot commented Jun 5, 2020

Hi @magento-engcom-team. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


@ghost ghost added this to Ready for Dev in Community Backlog Jun 5, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Jun 5, 2020
@nrkapoor nrkapoor added this to the 2.4.1 milestone Jun 5, 2020
@nrkapoor nrkapoor moved this from Ready for Dev to Good First Issue in Community Backlog Jun 10, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 16, 2020

Hi @gallyamov. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
      DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
    1. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@ghost ghost moved this from Good First Issue to Dev in Progress in Community Backlog Jun 16, 2020
@magento-engcom-team
Copy link
Contributor Author

❌ Something went wrong. Cannot update Jira issue (https://jira.corp.magento.com/browse/MC-34187).

5 similar comments
@magento-engcom-team
Copy link
Contributor Author

❌ Something went wrong. Cannot update Jira issue (https://jira.corp.magento.com/browse/MC-34187).

@magento-engcom-team
Copy link
Contributor Author

❌ Something went wrong. Cannot update Jira issue (https://jira.corp.magento.com/browse/MC-34187).

@magento-engcom-team
Copy link
Contributor Author

❌ Something went wrong. Cannot update Jira issue (https://jira.corp.magento.com/browse/MC-34187).

@magento-engcom-team
Copy link
Contributor Author

❌ Something went wrong. Cannot update Jira issue (https://jira.corp.magento.com/browse/MC-34187).

@magento-engcom-team
Copy link
Contributor Author

❌ Something went wrong. Cannot update Jira issue (https://jira.corp.magento.com/browse/MC-34187).

@gallyamov
Copy link
Contributor

gallyamov commented Jun 17, 2020

Hello @nishantjariwala could you confirm that the following response will work?

Request:

{
  storeConfig {
    id
    header_logo_src
    store_name
    website_id
    root_category_id
    stores {
      id
      store_name
      website_id
      copyright
    }
  }
}

Response:

{
  "data": {
    "storeConfig": {
      "id": 1,
      "header_logo_src": null,
      "store_name": null,
      "website_id": 1,
      "root_category_id": 2,
      "stores": [
        {
          "id": 1,
          "store_name": null,
          "website_id": 1,
          "copyright": "Copyright © 2013-present Magento, Inc. All rights reserved."
        },
        {
          "id": 2,
          "store_name": null,
          "website_id": 2,
          "copyright": "Test site copyright"
        }
      ]
    }
  }
}

@ghost ghost moved this from Ready for Dev to Dev in Progress in Community Backlog Jun 20, 2020
@ghost ghost removed the Progress: ready for dev label Jun 20, 2020
@nrkapoor nrkapoor moved this from Dev in Progress to PR In Progress in Community Backlog Jun 21, 2020
gallyamov added a commit that referenced this issue Jun 22, 2020
gallyamov added a commit that referenced this issue Jun 22, 2020
gallyamov added a commit that referenced this issue Jun 24, 2020
…ebsite

- Implemented new availableStores query

- Code refactor
@cpartica cpartica added the PAP Partners acceleration program label Jun 25, 2020
gallyamov added a commit that referenced this issue Jun 25, 2020
…ebsite

- Created separate test for available stores

Added website specific store output
gallyamov added a commit that referenced this issue Jun 26, 2020
gallyamov added a commit that referenced this issue Jun 30, 2020
gallyamov added a commit that referenced this issue Jun 30, 2020
gallyamov added a commit that referenced this issue Jul 1, 2020
…ebsite

- Fixed static code checks and web api tests
gallyamov added a commit that referenced this issue Jul 1, 2020
gallyamov added a commit that referenced this issue Jul 9, 2020
gallyamov added a commit that referenced this issue Jul 9, 2020
gallyamov added a commit that referenced this issue Jul 9, 2020
gallyamov added a commit that referenced this issue Jul 10, 2020
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jul 15, 2020
@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog Jul 15, 2020
AntonEvers added a commit to AntonEvers/magento2 that referenced this issue Jul 16, 2020
* upstream/2.4-develop: (592 commits)
  Write metadata to the GIF and PNG format
  Add metadata TO the test image
  Correct pagination behavior
  MQE-2220: fixed deprecated action group usage and annotation errors in MFTF tests
  add missing properties
  Fix namespaces
  remove protected property
  Cover changes with integration tests
  Fix static tests
  MC-20637: MyAccount :: Order Details :: Invoice Details by Order Number - fixed review comments
  Code review suggestions
  Introduce SearchAssets service
  magento#28569: Multi-store: Missing store codes in relation to a group and website
  MC-20637: MyAccount :: Order Details :: Invoice Details by Order Number - fixed review and static failures
  MQE-2220: updated mftf version to ^3.0  - removed deprecated action groups as they are removed from 2.4.0  - fixed test annotation errors
  MC-35776: WsdlGenerationFromDataObjectTest is failed with PHP 7.4.6
  MC-20637: MyAccount :: Order Details :: Invoice Details by Order Number - review fixes
  magento#28563: GraphQL product search does not consider Category Permissions configuration - Pass the context as argument
  magento#28569: Multi-store: Missing store codes in relation to a group and website
  MC-34649: Uses Per Coupon and Uses Per Customer not honored with concurrent orders
  ...
@magento-engcom-team magento-engcom-team added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch and removed Reproduced on 2.5.x labels Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed PAP Partners acceleration program Project: GraphQL Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
No open projects
Community Backlog
  
Done (last 30 days)
Development

Successfully merging a pull request may close this issue.

4 participants