Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customer Email with diacritics isn't allowed #12075

Closed
Drakhunter opened this issue Nov 7, 2017 · 14 comments · Fixed by #36027
Closed

Customer Email with diacritics isn't allowed #12075

Drakhunter opened this issue Nov 7, 2017 · 14 comments · Fixed by #36027
Assignees
Labels
Area: APIs Component: Customer Component: Email Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S1 Affects critical data or functionality and forces users to employ a workaround.

Comments

@Drakhunter
Copy link

Drakhunter commented Nov 7, 2017

Magento2 doesn't allow E-Mails with diacritics in CURL Requests.
According to wikipedia this should be allowed, but Magento is restricting it.

Is there a Fix or Workaround or something?

Preconditions

  1. Magento Version 2.1.8

Steps to reproduce

  1. get email address with diacritics (pepé@emailtest.com)
  2. create json data object with email
    $data = [ 'customer' => [ 'email' => pepé@emailtest.com ] ]
  3. create user using curl via /index.php/rest/V1/customers

Expected result

  1. User should be created with correct email address

Actual result

1. {"message":"\"Email\" ist keine g\u00fcltige E-Mail-Adresse." (roughly translated: Email isn't a valid E-Mail-Address)

Additional Notes

Reproduced it via Swagger with using the following query /swagger#/customerAccountManagementV1/customerAccountManagementV1CreateAccountPost
swagger_create customer
The response is :

{
  "message": "\"Email\" is not a valid email address."
}

But this is also reproducible if try to create a customer from Magento Admin
email_from admin

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Nov 7, 2017
@magento-engcom-team
Copy link
Contributor

@Drakhunter, thank you for your report.
We've created internal ticket(s) MAGETWO-83378 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Nov 7, 2017
@rparsi-boxycharm
Copy link

@magento-engcom-team any updates? We need a fix asap

@engcom-Bravo engcom-Bravo self-assigned this Jan 10, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 10, 2020

Hi @engcom-Bravo. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@engcom-Bravo engcom-Bravo added Component: Customer Component: Email Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jan 10, 2020
@ghost ghost unassigned engcom-Bravo Jan 10, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-30334 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@ProkopovVitaliy
Copy link
Contributor

@sdzhepa Looks like it is not bug this is default behavior. Even more, for this responsible not magento.

There is special class for validation Zend_Validate_EmailAddress his contain function where regular expression prohibits emails with such characters.

image

It is easy to fix but it is not Magento. So i think we can close current issue.

@rparsi-boxycharm
Copy link

@ProkopovVitaliy No, it is Magento because magento core code is using this. Magento customers such as myself need customer entity email addresses to support special characters like diacritics.
Magento team is responsible for fixing this.

@sidolov sidolov added this to Ready for Grooming in Low Priority Backlog Sep 3, 2020
@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Apr 28, 2022
@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Apr 28, 2022
@m2-community-project m2-community-project bot moved this from Dev In Progress to Ready for Development in High Priority Backlog May 12, 2022
@Alexander-Khohklov
Copy link
Contributor

@magento I am working on this

@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Aug 24, 2022
Alexander-Khohklov pushed a commit to Alexander-Khohklov/magento2 that referenced this issue Aug 25, 2022
 - fixed customer email with diacritics validation when create from admin panel or by curl request
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog Aug 25, 2022
@github-jira-sync-bot github-jira-sync-bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: ready for grooming labels Nov 17, 2022
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Dec 3, 2022
@m2-community-project m2-community-project bot added Progress: done and removed Progress: PR Created Indicates that Pull Request has been created to fix issue Progress: PR in progress labels Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: APIs Component: Customer Component: Email Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects