#12075 :- Customer Email with diacritics isn't allowed

[konarshankar07]

Description (*)

This PR will fix the issue with the email address validation for email address internationalization (EAI)

Fixed Issues (if relevant)

1. Fixes Customer Email with diacritics isn't allowed #12075

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @konarshankar07. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[konarshankar07]

@magento run all tests

[rogyar]

Hi @konarshankar07. Thank you for your work. Could you explain your fix, please? I see that you have removed the part that disables TLD validation. But validation of the name in the email (before @) still in place.

Also, you've removed the interface mention from the validator. Could you shed some light on the reason, please?

Thanks.

[konarshankar07]

Hello @rogyar
I think we should remove the zendframework1 dependency from the magento and use the Laminas dependency to the magento core that's why I removed the interface and TLD validation and extended the laminas Email validator.Let me know your thoughts
Thanks

[rogyar]

Hi @konarshankar07. That makes sense, thank you for the explanation.

In the current version, we have the TLD validation set to false. However, in Laminas hostname validator, the useTldCheck set to true by default. So it means that after your change the TLD will be validated (but should not).

Also, still not obvious how this change will fix validation of the THIS@mail.com part of the email address that may contain diacritics.

Could you clarify the mentioned points, please?

Thanks.

[engcom-Charlie]

Hi @konarshankar07. Could you please look at #31003 (comment)?
Thank you.

[engcom-Charlie]

Hi @konarshankar07, do you have any updates?

[engcom-Charlie]

Hi @konarshankar07. Could you please take a look at #31003 (comment)?
Thank you.

[engcom-Charlie]

@konarshankar07 @rogyar with changes from this PR we have the next error during install:
PHP Fatal error: Uncaught TypeError: Argument 1 passed to Magento\Framework\Validator\DataObject::addRule() must implement interface Zend_Validate_Interface, instance of Magento\Framework\Validator\EmailAddress given
At first, needs to change \Magento\Framework\Validator\DataObject::addRule parameter type which will affect other validators. You can fix it but this change could be delivered only to 2.5 version since \Magento\Framework\Validator\DataObject marked as api.

[engcom-Charlie]

@konarshankar07 please fix the issue mentioned above, I created a separate issue for removing a dependency here #31511.
Thank you.

[konarshankar07]

Hello @engcom-Charlie
Thanks for the update and I will fix this issue using the zendframework1

[konarshankar07]

@magento run all tests

[konarshankar07]

@magento run all tests

[konarshankar07]

@magento run all tests

[gabrieldagama]

Hi @konarshankar07, can you update this PR with the latest mainline also have a look at the failed tests?

Thanks!

[engcom-Foxtrot]

Hello, @konarshankar07. Unfortunately, we are closing this PR due to inactivity. If you want to continue your work on this issue, please one new one. Also, please do not replace the Zend_Validate with Laminas as such change poses a high risk.

[m2-assistant]

Hi @konarshankar07, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.