QuoteRepository get methods won't return CartInterface but Quote model

[msieprawski]

Preconditions

1. Magento 2.2.0 CE
2. PHP 7.024

Steps to reproduce

1. Create custom module with following etc/di.xml` file:

<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
    <preference for="Magento\Quote\Api\Data\CartInterface" type="Vendor\Module\Model\Quote" />
</config>

2. Create \Vendor\Module\Model\Quote object which extends \Magento\Quote\Model\Quote.
3. Now execute following code:

$objectManager = \Magento\Framework\App\ObjectManager::getInstance();
$cartRepository = $objectManager->create(\Magento\Quote\Api\CartRepositoryInterface::class);
$cartRepository->get(70); // use existing quote ID

Expected result

1. The result will be an object of instance Vendor\Module\Model\Quote

Actual result

1. Actual result is an object of instance Magento\Quote\Model\Quote

It's caused by invalid vendor/magento/module-quote/Model/QuoteRepository.php::loadQuote method which uses Magento\Quote\Model\QuoteFactory in the very first line instead of Magento\Quote\Api\Data\CartInterfaceFactory.

The solution is to override QuoteRepository's loadQuote method and use CartInterfaceFactory.

[msieprawski]

Any updates on this one?

[magento-engcom-team]

@msieprawski, thank you for your report.
We've acknowledged the issue and added to our backlog.

[cpjeanpaul]

So... ?

[m2-assistant]

Hi @Bartlomiejsz. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 2. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 3. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

[magento-engcom-team]

Hi @msieprawski. Thank you for your report.
The issue has been fixed in #22149 by @Bartlomiejsz in 2.3-develop branch
Related commit(s):

• 865d7df16d374246d91d35f1bdb737828c88edc8
• 6e079a341326aa7bf3a59848cbadbf2153eb4ae0
• fa5cf907e0bd9f0fda4431a551e798a911dfe875

The fix will be available with the upcoming 2.3.2 release.

[sidolov]

Hi @msieprawski. Thank you for your report.
The issue has been fixed in #22549 by @Bartlomiejsz in 2.2-develop branch
Related commit(s):

• 2a148f665eac3bcebf31110a456e373583946cd6
• ac0e9330ee930073fcc76b3345fc86cf3976193a

The fix will be available with the upcoming 2.2.10 release.