Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fix #12802 - allow to override preference over CartInterface and return correct object from QuoteRepository #22549

Conversation

Bartlomiejsz
Copy link
Contributor

@Bartlomiejsz Bartlomiejsz commented Apr 29, 2019

Original Pull Request

#22149

Description (*)

This is fix for #12802

Fixed Issues (if relevant)

  1. QuoteRepository get methods won't return CartInterface but Quote model #12802: QuoteRepository get methods won't return CartInterface but Quote model

Manual testing scenarios (*)

Steps are described in #12802

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Bartlomiejsz and others added 2 commits April 29, 2019 22:20
…Api\Data\CartInterface and return correct object from QuoteRepository (+4 squashed commits) Squashed commits: [55b9f3ec52b] Fix magento#12802 - fix phpmd, mark quoteFactory as deprecated [56ca9a42468] Fix magento#12802 - change condition in quoteRepository [734212812a4] Fix magento#12802 - revert change of constructor parameters names [ba8ad543e0f] Fix magento#12802 - remove instanceof condition
@m2-assistant
Copy link

m2-assistant bot commented Apr 29, 2019

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4855 has been created to process this Pull Request

@m2-assistant
Copy link

m2-assistant bot commented May 7, 2019

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request May 7, 2019
…r CartInterface and return correct object from QuoteRepository #22549
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.10 milestone May 7, 2019
@Bartlomiejsz Bartlomiejsz deleted the 2.2-develop-PR-port-22149 branch August 25, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants