Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Store: "Store View" sort order values are not reflected in the admin or front-end store-switcher #13401

Closed
duffner opened this issue Jan 28, 2018 · 9 comments · Fixed by #28163
Assignees
Labels
Component: Store Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers

Comments

@duffner
Copy link

duffner commented Jan 28, 2018

Preconditions

  1. Magento 2.2.2
  2. PHP 7.0

Steps to reproduce

  1. Create one website, with three Store Groups Each with 1 store
  2. Within the Store view 1, set priority of 0, Store View 2, priority of 10, Store View 3, priority of 20
  3. Save
  4. Reviewing admin grid of stores, the sort order does not change.
  5. Reviewing store switcher on front-end, sort order does not change

screen shot 2018-01-28 at 1 40 37 am

Expected result

  1. When changing the sort order of stores in the admin, their new sort order should be reflected on the admin grid and main store switcher.

Actual result

  1. Nothing changes

This feature works as expected in Magento 1.14.x and 1.9.x. The business case, I want to be able to arrange my stores in the store switcher drop down by popularity or other arbitrary value. This is not possible as the sort order value does nothing. Additionally, if I have 100 stores, I want to be able to sort them in a way that makes sense in the admin.

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jan 28, 2018
@duffner duffner changed the title Multi-Store setting sort order on store views is not reflected in the admin or storefront Multi-Store: Store View" sort order values are not reflected in the admin or front-end store-switcher Jan 28, 2018
@duffner duffner changed the title Multi-Store: Store View" sort order values are not reflected in the admin or front-end store-switcher Multi-Store: "Store View" sort order values are not reflected in the admin or front-end store-switcher Jan 28, 2018
@duffner
Copy link
Author

duffner commented Jan 28, 2018

An additional bug relating to Enterprise Support Ticket #03228684:

When switching stores, if a url key for a category is not valid on the second store the native store switcher places user onto a 404 page. This issue also exists in plain 2.2.2 with no customizations.

@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Jan 29, 2018
@magento-engcom-team
Copy link
Contributor

@duffner, thank you for your report.
We've acknowledged the issue and added to our backlog.

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Jan 29, 2018
@duffner
Copy link
Author

duffner commented Feb 25, 2018

@vasilii-b , I'm adding you to this ticket as you were already in the Store Switcher Logic for a separate ticket and this is the last piece to allowing the store switcher to work as expected for Magento 2 merchants. I was curious if you had any interest in taking this on as well.

@vasilii-b
Copy link

For the admin panel, I've found responsible method joinGroupAndStore from Magento\Store\Model\ResourceModel\Website\Collection.

/**
* Join group and store info from appropriate tables.
* Defines new _idFiledName as 'website_group_store' bc for
* one website can be more then one row in collection.
* Sets extra combined ordering by group's name, defined
* sort ordering and store's name.
*
* @return $this
*/
public function joinGroupAndStore()

But I do not understand why there is the need to sort by Group Name, Store View Name and Store View Order.
Can anyone form Magento Team (as the Annotation says these order lines were added by team) suggest why it's so ? @magento-engcom-team Where we can read more about it, the reason of doing so ?

Thank you!

@magento-engcom-team magento-engcom-team added this to Ready for Dev in Community Backlog Mar 24, 2020
@ghost ghost assigned Bartlomiejsz May 8, 2020
@ghost ghost moved this from Ready for Dev to PR In Progress in Community Backlog May 8, 2020
Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue May 8, 2020
…ot reflected in front-end store-switcher
Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue May 16, 2020
@ghost ghost added Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Priority: P3 May be fixed according to the position in the backlog. labels May 19, 2020
@sdzhepa sdzhepa added the Triage: Done Has been reviewed and prioritized during Triage with Product Managers label Jun 2, 2020
@sdzhepa sdzhepa removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jun 11, 2020
@ghost ghost moved this from PR In Progress to Ready for QA in Community Backlog Jun 11, 2020
@sdzhepa sdzhepa added Progress: PR in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Jun 11, 2020
@ghost ghost moved this from Ready for QA to Ready for Dev in Community Backlog Jun 11, 2020
@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jun 11, 2020
@magento-engcom-team
Copy link
Contributor

@sdzhepa Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • Add "Component: " label(s) to this ticket based on verification result. If uncertain, you may follow the best guess

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@ghost ghost moved this from Ready for Dev to Ready for QA in Community Backlog Jun 11, 2020
@sdzhepa sdzhepa added Component: Store Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jun 11, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @sdzhepa
Thank you for verifying the issue. Based on the provided information internal tickets MC-35092 were created

Issue Available: @sdzhepa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@ghost ghost moved this from Ready for QA to Ready for Dev in Community Backlog Jun 11, 2020
@AbdulRahmanAbouzaid
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @AbdulRahmanAbouzaid. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@ghost ghost moved this from Ready for Dev to PR In Progress in Community Backlog Aug 8, 2020
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Aug 26, 2020
@magento-engcom-team
Copy link
Contributor

Hi @duffner. Thank you for your report.
The issue has been fixed in #28163 by @Bartlomiejsz in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog Aug 26, 2020
magento-engcom-team added a commit that referenced this issue Aug 26, 2020
… are not reflected in front-end store-switcher #28163

 - Merge Pull Request #28163 from Bartlomiejsz/magento2:feature/fix_13401_store_view_sort_order_FE
 - Merged commits:
   1. 85b6d05
   2. 47bc47b
   3. e87199e
   4. 06a5ac4
   5. a78ddde
magento-engcom-team pushed a commit that referenced this issue Aug 26, 2020
… are not reflected in front-end store-switcher #28163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Store Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
No open projects
Community Backlog
  
Done (last 30 days)
6 participants