Fix #13401 - Multi-Store: "Store View" sort order values are not reflected in front-end store-switcher

[Bartlomiejsz]

Description (*)

This fixes #13401
However I only modified sort order on FE, since on admin grid it seems to be sorted alphabetically, and not sure if that should be changed. If yes, I can adjust PR.

Related Pull Requests

Fixed Issues (if relevant)

1. Multi-Store: "Store View" sort order values are not reflected in the admin or front-end store-switcher #13401: Multi-Store: "Store View" sort order values are not reflected in the admin or front-end store-switcher

Manual testing scenarios (*)

1. Create one website, with three Store Groups Each with 1 store
2. Within the Store view 1, set priority of 0, Store View 2, priority of 10, Store View 3, priority of 20
3. Review store switcher on front-end, sort order should impact order of stores visible

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[aleron75]

Hello @Bartlomiejsz. Thanks for your pull request.
I'm re-running some functional tests because they failed, meanwhile can you please take a look at the conflicts on app/code/Magento/Store/Test/Unit/Block/SwitcherTest.php?
My best,
Alessandro

[Bartlomiejsz]

Hi @aleron75, done

[aleron75]

Hi @aleron75, done

Thanks! Unfortunately, some functional tests fail, may I ask you to take a look at them?

My best,
Alessandro

[Bartlomiejsz]

Hi @aleron75, done

Thanks! Unfortunately, some functional tests fail, may I ask you to take a look at them?

My best,
Alessandro

I checked all of failed tests, and none of those seem to be related to store switcher, so doesn't seem to be caused by my changes...

[aleron75]

Hello,
I also asked internally to understand whether there are some issues with the functional testing suite.
I'll keep you posted.
My best.

[aleron75]

Hello @Bartlomiejsz, it seems that the functional tests that fail are flaky, so I proceed to approve this PR.

[magento-engcom-team]

Hi @aleron75, thank you for the review.
ENGCOM-7543 has been created to process this Pull Request

[engcom-Alfa]

@magento give me test instance

[magento-engcom-team]

Hi @engcom-Alfa. Thank you for your request. I'm working on Magento instance for you

[engcom-Alfa]

Hi @Bartlomiejsz.

Unfortunately, looks like your changes don't solve the issue #13401

Manual testing scenario:

1. A website with 3 Stores each with 1 Store view;
   

2. Set sort order for store views:

• Default -> 0
• Second Store View -> 30
• Third Store View -> 20

3. Go to Storefront;

Actual Result: ✖️ Sorting has not changed

Expected Result: ✔️ The Third Store should be above the Second Store

@Bartlomiejsz Could you take a look?

Thanks!

[engcom-Echo]

@magento run all tests

[engcom-Echo]

@magento run all tests

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-7543 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. A website with 3 Stores (2 with 1 Store view and one with 3Store views);
   

2. Set sort order for store views:

• Default -> 0
• Second Store View -> 20
• Third Store View -> 10
• Third Store View (3) -> 11
• Third Store View (2) -> 12

3. Go to Storefront;

Before: ✖️ Sorting has not changed

After: ✔️ Stores have correct sorting

[m2-assistant]

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.