Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute 'setup_version' is missing for module error when defined as optional #1493

Closed
markshust opened this issue Jul 16, 2015 · 3 comments

Comments

Projects
None yet
5 participants
@markshust
Copy link
Contributor

commented Jul 16, 2015

Using the defined module.xml when creating a module:

<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/Module/etc/module.xsd">
    <module name="Foo_Bar" />
</config>

Leads to this error: Attribute 'setup_version' is missing for module

However as defined by lib/internal/Magento/Framework/Module/etc/module.xsd, this is an optional field:
<xs:attribute name="setup_version" type="setupVersion" use="optional" />

@joanhe

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2015

Thanks for reporting this issue. Internal issue MAGETWO-40320 is created.

@dsikkema-magento

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2015

Hi @markoshust! Again, thanks for the report, we're tracking it. I just wanted to mention how we're planning to fix this: setup_version will become a required attribute, to reflect the fact that it really is required.

dsikkema-magento pushed a commit that referenced this issue Oct 7, 2015

@mazhalai

This comment has been minimized.

Copy link
Contributor

commented Dec 31, 2015

@markoshust This issue has been fixed in 2.0.0, hence closing this issue.

@mazhalai mazhalai closed this Dec 31, 2015

magento-team pushed a commit that referenced this issue Sep 14, 2017

Merge pull request #1493 from magento-engcom/develop-prs
[EngCom] Public Pull Requests
 - MAGETWO-75114: Deprecated Magento\Store\Model\Store::$_isAdminSecure #10877
 - MAGETWO-72539: cviking26_issue-9489 // added query param to url build - description … #10848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.