Magento 2.2.5: Google Analytics not added to head correctly #16497

WalterSmulders · 2018-07-03T09:31:32Z

Preconditions

Magento version 2.2.5
PHP 7.1
MariaDB 15.1
NginX 1.13.8

Steps to reproduce

Enable Google Analytics trough admin Stores -> Configuration -> Sales -> Google API
Fill in account number
Save configuration
Clear cache

Expected result

Google Analytics JavaScript should be loaded on the frontend

Actual result

Google Analytics isn't added at all on the frontend.

I managed to find the problem myself. In Magento 2.2.5 the file Magento_GoogleAnalytics/view/frontend/layout/default.xml was changed.

It now injects the Google Analytics block trough:
<referenceContainer name="head.additional">

But head.additional isn't a container but a block.

The fix I am using is to create a file:
app/design/frontend/-THEME VENDOR-/-THEME NAME-/Magento_GoogleAnalytics/layout/override/base/default.xml

with following content:

<?xml version="1.0"?> <page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd"> <body> <referenceContainer name="head.additional"> <block class="Magento\GoogleAnalytics\Block\Ga" name="google_analytics" as="google_analytics" template="Magento_GoogleAnalytics::ga.phtml"/> </referenceContainer> </body> </page>

The text was updated successfully, but these errors were encountered:

magento-engcom-team · 2018-07-03T09:31:38Z

Hi @WalterSmulders. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@WalterSmulders do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

yes
no

engcom-backlog-nickolas · 2018-07-04T07:28:51Z

@WalterSmulders, thank you for your report. I've checked this issue on Magento 2.2.5, and google-analytics.js loads for me on storefront just fine.

ishakhsuvarov · 2018-07-04T07:50:03Z

Adding link to the Pull Request where this was introduced: #14293

engcom-backlog-nickolas · 2018-07-19T07:52:56Z

@WalterSmulders, we are closing this issue due to inactivity. If you'd like to update it, please reopen the issue.

eamontaylor · 2018-09-08T15:20:11Z

Did this issue ever get resolved as i'm having the same issue?

DanielRuf · 2018-09-09T09:46:01Z

Probably not. So before this it was a block and now it is a container?

This would be a breaking change which affects all who overwrite default.xml (which is the case when you create a custom theme or extend theme files).

eamontaylor · 2018-09-09T10:05:34Z

@DanielRuf Thanks. I think the default theme has changed, i've inherited a project, and updated it from 2.1.8 to 2.2.5 do you know what the fix is for this?

DanielRuf · 2018-09-09T10:33:06Z

The fix for us who have a custom or other theme based on Blank / Luma have to port the changes to the overwritten / changed files. Good to know, will have to check this also for one of our projects.

DanielRuf · 2018-09-09T10:34:12Z

Basically doing a diff (changing block to container).

DanielRuf · 2018-09-09T10:34:56Z

We have to check here if 2.2.5 or a previous release introduced this change.

ghost · 2018-09-10T12:15:25Z

Hi @DanielRuf seem this issue was fixed in 2.2.5 but if you have a custom theme you need overwrite odefault.xml to origin luma or blank file ?
Hi @eamontaylor Did you solve your problem ?

eamontaylor · 2018-09-10T12:24:00Z

Hi I've updated the following default.xml file it's not working so i guess it's not the right path.

app/design/frontend/-THEME VENDOR-/-THEME NAME-/Magento_Theme/layout/default.xml

<?xml version="1.0"?> <page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd"> <body> <referenceContainer name="head.additional"> <block class="Magento\GoogleAnalytics\Block\Ga" name="google_analytics" as="google_analytics" template="Magento_GoogleAnalytics::ga.phtml"/> </referenceContainer> <referenceBlock name="reviews.tab" remove="true" /> <referenceBlock name="product.review.form" remove="true" /> <referenceBlock name="product.info.review" remove="true" /> <referenceBlock name="category.product.addto" remove="true" /> <referenceBlock name="related.post.tab" remove="true" /> </body> </page>

What file exactly do I need to update?

ghost · 2018-09-10T12:27:44Z

@eamontaylor this is right path -> app/design/frontend/-THEME VENDOR-/-THEME NAME-/Magento_GoogleAnalytics/layout/override/base/default.xml

eamontaylor · 2018-09-10T12:35:26Z

@engcom-backlog-nazar nope this doesn't work for me.

Upgraded, Compiled, Deployed, Cleared cache and still nothing,

ghost · 2018-09-10T12:37:05Z

@eamontaylor did you clear pub static files?

WalterSmulders · 2018-09-10T12:37:27Z

@eamontaylor If you correctly override the XML it will work, I have this fix in place in several live Magento installs

ghost · 2018-09-10T12:45:14Z

@eamontaylor you may do something wrong, i do this with custom theme and it works perfectly.

ghost · 2018-09-10T13:02:41Z

@DanielRuf Can i close issue ? or leave open, until somebody change name from container to block ?

eamontaylor · 2018-09-10T13:22:46Z

Do i need to change refernceContainer to referenceBlock?

ghost · 2018-09-10T13:48:25Z

@eamontaylor yes but seems it's not solve your problem.

eamontaylor · 2018-09-10T14:14:38Z

@engcom-backlog-nazar Thanks, i've tried everything you've suggested but still no joy.

eamontaylor · 2018-09-10T17:27:04Z

@DanielRuf Yep cleared the caches again and that seems to of sorted it thanks everyone.

hostep · 2018-09-10T17:51:12Z

I believe @WalterSmulders has a point here.

head.additional is created as a Block
Is being referenced correctly in the catalog module
Is being incorrectly referenced as a container in the google analytics module

The strange thing is, that this seems to work perfectly fine. So you can reference a block using referenceContainer which is not what I expected.

I'm not sure if customisations can break this somehow, but I think it would be best that the referenceContainer is replaced with referenceBlock in the google analytics module.

ghost · 2018-09-11T05:32:05Z

@WalterSmulders , thank you for your report.
We've acknowledged the issue and added to our backlog.

WalterSmulders · 2018-09-11T05:45:44Z

@engcom-backlog-nazar happy to hear the bug is acknowledged and it will be fixed

sambolek · 2018-09-27T13:48:41Z

#mm18hr

slavvka · 2018-10-03T21:20:09Z

Hi @WalterSmulders. Thank you for your report.
The issue has been fixed in #18290 by @sambolek in 2.3-develop branch
Related commit(s):

f6fcf413f19d962d9f29763f1504849924c20fa0

The fix will be available with the upcoming 2.3.1 release.

magento-engcom-team · 2018-10-04T17:25:06Z

Hi @WalterSmulders. Thank you for your report.
The issue has been fixed in #18375 by @sambolek in 2.2-develop branch
Related commit(s):

018901480f9d9be3e7813d7b91d32cbd45f82140

The fix will be available with the upcoming 2.2.8 release.

Good afternoon, Just one typo error with the script declaration "Smile_ElasticsuiteTracker::js/tracking.js" (anyway, it include correctly this javascript file). And some inconsistents with the declaration of head.additional which is a block not a container (Same problem on Magento_GoogleAnalytics, this is not solved in my version of Magento 2.3 - magento/magento2#16497) Personally, I would rather move the script tracking.js into the before.body.end before block smile.tracker.page.base. I think you recommends to place it in the <head>, so if someone aborts a load of the page, the script might get executed. "It helps you to accurately record traffic stats because your header scripts are loaded earlier than any other scripts on your page." Cheers, Ilan PARMENTIER

Rickertje · 2019-05-07T15:36:05Z

I am on 2.2.7. I experience the exact same issue with the Adwords block (... while the Analytics block is working for me). Any comments on that?

Rickertje · 2019-05-08T08:52:16Z

@WalterSmulders can you please make a comment on this?

WalterSmulders · 2019-05-08T08:58:34Z

@WalterSmulders can you please make a comment on this?

I did not experience this issue. I recommend to see if the fix I gave in the opening post can be applied to the Adwords block, furthermore I think it's wise to treat this as a separate issue since this one is closed and likely contains a other part of the code.

Rickertje · 2019-05-08T09:02:49Z

@WalterSmulders ok thanks I wil investigate and post a new issue if necessary

pioneerathletics · 2019-05-10T13:50:37Z

The Google Analytics code is still not being properly added to the head in 2.2.8. I applied the fix in 2.2.7 as a layout extension - theme-dir/Magento_GoogleAnalytics/layout/default and it worked properly in 2.2.7 after it was applied. I upgraded to 2.2.8 and removed the layout customization, but now the code is not being added properly as it was before. Also, I have cleared all my caches but that hasn’t solved my issue.

pioneerathletics · 2019-05-10T15:33:30Z

I resolved my issue. It was due to another layout extension I had within theme-dir/Magento_Catalog/layout/default.xml. I didn't realize that the latest fix in 2.2.8 referenced that.

magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jul 3, 2018

WalterSmulders changed the title ~~Google Analytics not added to head~~ Magento 2.2.5: Google Analytics not added to head correctly Jul 3, 2018

engcom-backlog-nickolas self-assigned this Jul 4, 2018

engcom-backlog-nickolas added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Progress: needs update labels Jul 4, 2018

engcom-backlog-nickolas closed this as completed Jul 19, 2018

engcom-backlog-nickolas removed their assignment Jul 19, 2018

DanielRuf reopened this Sep 9, 2018

ghost self-assigned this Sep 10, 2018

ghost removed their assignment Sep 11, 2018

magento-engcom-team added the Event: mm18hr label Sep 27, 2018

sambolek self-assigned this Sep 27, 2018

sambolek mentioned this issue Sep 27, 2018

Fix wrong reference in google analytics module layout xml #18290

Merged

4 tasks

slavvka added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Oct 3, 2018

sambolek mentioned this issue Oct 4, 2018

Backport 2.2 - Fix wrong reference in google analytics module layout xml #18375

Merged

4 tasks

magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Oct 4, 2018

magento-engcom-team closed this as completed Oct 4, 2018

Amadeco mentioned this issue Jan 18, 2019

head.additional declaration Smile-SA/elasticsuite#1273

Merged

qdb mentioned this issue Apr 4, 2019

Use referenceBlock instead of referenceContainer justbetter/magento2-sentry#18

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Magento 2.2.5: Google Analytics not added to head correctly #16497

Magento 2.2.5: Google Analytics not added to head correctly #16497

WalterSmulders commented Jul 3, 2018 •

edited

Loading

magento-engcom-team commented Jul 3, 2018

engcom-backlog-nickolas commented Jul 4, 2018

ishakhsuvarov commented Jul 4, 2018

engcom-backlog-nickolas commented Jul 19, 2018

eamontaylor commented Sep 8, 2018 •

edited

Loading

DanielRuf commented Sep 9, 2018

eamontaylor commented Sep 9, 2018 •

edited

Loading

DanielRuf commented Sep 9, 2018

DanielRuf commented Sep 9, 2018

DanielRuf commented Sep 9, 2018

ghost commented Sep 10, 2018

eamontaylor commented Sep 10, 2018

ghost commented Sep 10, 2018

eamontaylor commented Sep 10, 2018 •

edited

Loading

ghost commented Sep 10, 2018

WalterSmulders commented Sep 10, 2018

ghost commented Sep 10, 2018

ghost commented Sep 10, 2018

eamontaylor commented Sep 10, 2018

ghost commented Sep 10, 2018

eamontaylor commented Sep 10, 2018

eamontaylor commented Sep 10, 2018

hostep commented Sep 10, 2018

ghost commented Sep 11, 2018

WalterSmulders commented Sep 11, 2018

sambolek commented Sep 27, 2018

slavvka commented Oct 3, 2018

magento-engcom-team commented Oct 4, 2018

Rickertje commented May 7, 2019

Rickertje commented May 8, 2019

WalterSmulders commented May 8, 2019

Rickertje commented May 8, 2019 •

edited

Loading

pioneerathletics commented May 10, 2019

pioneerathletics commented May 10, 2019

Magento 2.2.5: Google Analytics not added to head correctly #16497

Magento 2.2.5: Google Analytics not added to head correctly #16497

Comments

WalterSmulders commented Jul 3, 2018 • edited Loading

Preconditions

Steps to reproduce

Expected result

Actual result

magento-engcom-team commented Jul 3, 2018

engcom-backlog-nickolas commented Jul 4, 2018

ishakhsuvarov commented Jul 4, 2018

engcom-backlog-nickolas commented Jul 19, 2018

eamontaylor commented Sep 8, 2018 • edited Loading

DanielRuf commented Sep 9, 2018

eamontaylor commented Sep 9, 2018 • edited Loading

DanielRuf commented Sep 9, 2018

DanielRuf commented Sep 9, 2018

DanielRuf commented Sep 9, 2018

ghost commented Sep 10, 2018

eamontaylor commented Sep 10, 2018

ghost commented Sep 10, 2018

eamontaylor commented Sep 10, 2018 • edited Loading

ghost commented Sep 10, 2018

WalterSmulders commented Sep 10, 2018

ghost commented Sep 10, 2018

ghost commented Sep 10, 2018

eamontaylor commented Sep 10, 2018

ghost commented Sep 10, 2018

eamontaylor commented Sep 10, 2018

eamontaylor commented Sep 10, 2018

hostep commented Sep 10, 2018

ghost commented Sep 11, 2018

WalterSmulders commented Sep 11, 2018

sambolek commented Sep 27, 2018

slavvka commented Oct 3, 2018

magento-engcom-team commented Oct 4, 2018

Rickertje commented May 7, 2019

Rickertje commented May 8, 2019

WalterSmulders commented May 8, 2019

Rickertje commented May 8, 2019 • edited Loading

pioneerathletics commented May 10, 2019

pioneerathletics commented May 10, 2019

WalterSmulders commented Jul 3, 2018 •

edited

Loading

eamontaylor commented Sep 8, 2018 •

edited

Loading

eamontaylor commented Sep 9, 2018 •

edited

Loading

eamontaylor commented Sep 10, 2018 •

edited

Loading

Rickertje commented May 8, 2019 •

edited

Loading