Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block totalbar not used in invoice create and credit memo create screens #16655

Closed
dverkade opened this issue Jul 9, 2018 · 5 comments
Closed
Labels
Component: Sales Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@dverkade
Copy link
Member

dverkade commented Jul 9, 2018

In the following layout files the Magento\Sales\Block\Adminhtml\Order\Totalbar block is defined:

  • sales_order_creditmemo_new.xml
  • sales_order_creditmemo_updateqty.xml
  • sales_order_invoice_new.xml
  • sales_order_invoice_updateqty.xml

However up on investigation I found that this block doesn't do anything and seems to be deprecated. Even when it does render something there is no styling. All styling is in the file styles-old.less and styling can not be found in the style.less file of the Magento adminhtml theme.

Preconditions

  1. Magento 2.2.5

Steps to reproduce

  1. Install Magento
  2. Create an invoice and an credit memo.

Expected result

  1. Totalbar block renders something.

Actual result

  1. Block doesn't render anything.
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jul 9, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jul 9, 2018

Hi @dverkade. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@dverkade do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@engcom-backlog-nickolas engcom-backlog-nickolas added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Component: Sales Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Jul 18, 2018
@engcom-backlog-nickolas

Hello @dverkade, thank you for your report and pull request.
We've acknowledged the issue and added to our backlog.

@engcom-backlog-nickolas engcom-backlog-nickolas removed their assignment Jul 18, 2018
@magento-engcom-team
Copy link
Contributor

Hi @dverkade. Thank you for your report.
The issue has been fixed in #16656 by @dverkade in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.7 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Aug 7, 2018
magento-engcom-team added a commit that referenced this issue Aug 7, 2018
…nd credit memo create screens #16656

 - Merge Pull Request #16656 from dverkade/magento2:2.2-removed-unused-totalbar
 - Merged commits:
   1. 19bff30
magento-engcom-team pushed a commit that referenced this issue Aug 7, 2018
@sidolov sidolov added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Aug 8, 2018
@sidolov
Copy link
Contributor

sidolov commented Aug 8, 2018

Hi @dverkade. Thank you for your report.
The issue has been fixed in #17413 by @dverkade in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.16 release.

magento-engcom-team added a commit that referenced this issue Aug 8, 2018
…ce create and credit memo create screens #17413

 - Merge Pull Request #17413 from dverkade/magento2:2.1-removed-unused-totalbar
 - Merged commits:
   1. db166c7
magento-engcom-team pushed a commit that referenced this issue Aug 8, 2018
@magento-engcom-team
Copy link
Contributor

Hi @dverkade. Thank you for your report.
The issue has been fixed in #17414 by @dverkade in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Aug 10, 2018
magento-engcom-team added a commit that referenced this issue Aug 10, 2018
…oice create and credit memo create screens #17414

 - Merge Pull Request #17414 from dverkade/magento2:2.3-removed-unused-totalbar
 - Merged commits:
   1. 1fe1251
magento-engcom-team pushed a commit that referenced this issue Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Sales Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

4 participants