Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bank Transer Payment Instuctions switch back to default #17933

Closed
rstylenl opened this issue Sep 5, 2018 · 8 comments · Fixed by #26765
Closed

Bank Transer Payment Instuctions switch back to default #17933

rstylenl opened this issue Sep 5, 2018 · 8 comments · Fixed by #26765
Assignees
Labels
Component: Payment Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@rstylenl
Copy link

rstylenl commented Sep 5, 2018

Summary (*)

The default Magento 2 Bank Transfer Payment has an issue when you have multiple stores.
If you create an order and select Bank Transfer Payment as payment method. Then go look at the just created order the title doesn't reflect the one we have setup in the store configuration. (Says: Bank Transfer Payment instead of "Überweisung (per Bank)"

The instructions are fine. But if you click Ship, Invoice the instuction gets reset to the default value that is in the system->configuration.

Preconditions (*)

  1. Magento 2.2.x, 2.3.x, 2.4-develop
  2. PHP 7.1, 7.2

Steps to reproduce (*)

  1. Create second store & store view.

  2. Enable Bank Transfer Payment.
    image

  3. Change title & instructions of Bank Transfer Payment for second store.
    image

  4. Create a new order with Bank Transfer Payment from second store.

  5. Go to the Order information in the backend.
    1

  6. Check email
    2

  7. Then click invoice or ship.

  8. Check order info again in the backend & email

Expected result (*)

  1. Payment information should be collected from the store the orde was placed in.

Actual result (*)

  1. Payment information show the default information from Store configuration. (in backend and in emails for Invoice/Shipment):
    Admin:
    3
    Email:
    4
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Sep 5, 2018
@magento-engcom-team
Copy link
Contributor

Hi @rstylenl. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@rstylenl do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@ghost ghost self-assigned this Sep 5, 2018
@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Component: Payment Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Sep 5, 2018
@ghost
Copy link

ghost commented Sep 5, 2018

Hi @rstylenl , thank you for your report.
We've acknowledged the issue and added to our backlog.

@ghost ghost added the Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release label Sep 5, 2018
@ghost ghost removed their assignment Sep 5, 2018
@ktpl-prakash ktpl-prakash self-assigned this Sep 8, 2018
@rstylenl
Copy link
Author

Small update - Even when you cancel the order the payment information will revert to the default config info.

@rstylenl
Copy link
Author

rstylenl commented Nov 1, 2018

@engcom-backlog-nazar @prakashpatel07

I have just tested this on a Vanilla Magento 2.2.3 installation and the payment information was as expected so it did not change it back to the default store. In the email that is send to the 'client' the Payment information Title is reset to the default store, but the Instructions are from the store the client order at. See screenshots below (i removed my personal info).

After placing the order (Backend):
order-placed

Info in Email after order is created:
order-placed-email

After creating the invoice: (Backend)
after-invoice-order

Info in Email after creating invoice:
invoice-email

In the invoice email the title of the payment method is reset to the Default store.
Store title is set to: Virement bancaire like you see in the backend.
Payment instructions however are correct.

@ghost ghost unassigned ktpl-prakash Sep 27, 2019
@engcom-Charlie engcom-Charlie self-assigned this Dec 31, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 31, 2019

Hi @engcom-Charlie. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@engcom-Charlie engcom-Charlie added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Dec 31, 2019
@ghost ghost unassigned engcom-Charlie Dec 31, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Charlie
Thank you for verifying the issue. Based on the provided information internal tickets MC-30147 were created

Issue Available: @engcom-Charlie, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Dec 31, 2019
@Bartlomiejsz Bartlomiejsz self-assigned this Feb 7, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 7, 2020

Hi @Bartlomiejsz. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@Bartlomiejsz Bartlomiejsz added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Feb 7, 2020
Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Feb 20, 2020
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Feb 28, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rstylenl. Thank you for your report.
The issue has been fixed in #26765 by @Bartlomiejsz in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

magento-engcom-team added a commit that referenced this issue Feb 28, 2020
…ack to default #26765

 - Merge Pull Request #26765 from Bartlomiejsz/magento2:feature/fix_17933_bank_transfer_instructions_default
 - Merged commits:
   1. 7c4be6a
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Payment Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants