Magento 2.2.6 coupon codes don't work anymore #18183

Cristiano81 · 2018-09-21T15:44:57Z

Preconditions

Magento 2.2.6
Cart price rule based on coupon code

Steps to reproduce

Create a cart price rule with specific coupon with date from 2018 to 2088
Try add the coupon to the cart

Expected result

The coupon has been successfull applied to the cart

Actual result

Every coupon code result invalid

magento-engcom-team · 2018-09-21T15:45:03Z

Hi @Cristiano81. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@Cristiano81 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

yes
no

Cristiano81 · 2018-09-21T15:45:14Z

In 2.2.5 the coupon code work

Cristiano81 · 2018-09-21T15:45:26Z

@magento-engcom-team give me 2.2.6 instance

magento-engcom-team · 2018-09-21T15:45:33Z

Hi @Cristiano81. Thank you for your request. I'm working on Magento 2.2.6 instance for you

magento-engcom-team · 2018-09-21T15:46:12Z

Hi @Cristiano81, here is your Magento instance.
Admin access: https://i-18183-2-2-6.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

Cristiano81 · 2018-09-21T15:49:52Z

yes i can reproduce the issue on vanilla magento

Cristiano81 · 2018-09-21T17:10:38Z

This maybe be usefull, when i try to apply the coupon code, i received this error on chrome console:
jquery.js:10254 PUT https://i-18183-2-2-6.engcom.dev.magento.com/rest/default/V1/guest-carts/BWM5XQCXhnzdxK9njKSP2cL611NFTmcG/coupons/TEST2018 404 (Not Found)
send @ jquery.js:10254
ajax @ jquery.js:9738
put @ storage.js:62
(anonymous) @ set-coupon-code.js:33
apply @ discount.js:41
(anonymous) @ knockout.js:3863
dispatch @ jquery.js:5226
elemData.handle @ jquery.js:4878

kunj1988 · 2018-09-22T08:31:49Z

@Cristiano81, I have tried with vanilla Magento 2.2.6 and it is working for me, Please provide more details.

Cristiano81 · 2018-09-22T13:10:32Z

@magento-engcom-team give me 2.2.6 instance

magento-engcom-team · 2018-09-22T13:10:37Z

Hi @Cristiano81. Thank you for your request. I'm working on Magento 2.2.6 instance for you

magento-engcom-team · 2018-09-22T13:11:16Z

Hi @Cristiano81, here is your Magento instance.
Admin access: https://i-18183-2-2-6.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

Cristiano81 · 2018-09-22T13:20:58Z

@kunj1988 thank you,
i just created a test product with price 100$

after that i created a new coupon with this attribute:

after i add the test product in cart and try to apply the coupon discount, this is the result:

maybe you can tell me your coupon configuration if it works

hostep · 2018-09-22T13:23:32Z

@Cristiano81 : the coupon codes in your screenshot don't match: TEST20118 vs TEST2018, please make sure they are the same ;)

Cristiano81 · 2018-09-22T13:27:00Z

ops you are right :P but even if they are the same it doesn't work,
please try on the active vanilla magento

hostep · 2018-09-22T14:03:43Z

Ok, I was able to reproduce, and also found out why.

It has to do with the "to date". In your example, you put it in the year 2088.
When I first tested, I just used 2018 and it worked perfectly fine.

After some playing around, it looks like the limit is 20 years, the year 2037 works, but the year 2038 no longer works.

So this is pretty strange.
You say it worked before on Magento 2.2.5? Also with the year 2088?
If yes: then you've found a new bug, but the fix is pretty easy. But I still consider it a bug if it worked in Magento 2.2.5, because this is kind of unexpected.

hostep · 2018-09-22T14:16:39Z

Hmm, just tested on Magento 2.2.5, it has the exact same problem, so it's not a new bug in 2.2.6. But it's certainly a problem.

Cristiano81 · 2018-09-22T14:20:27Z

Thank you for your support!
I can tell y the same, in 2.2.5 it didn't work with 2088, BUT it worked with blank "to date" , it does not in 2.2.6 .
I'm going to set an early "to date" thank y again

hostep · 2018-09-22T14:47:21Z

Hmm, I can not confirm the problem with the blank "to date".
See the test instance, I've added a new coupon with code TEST2020 with a blank "to date". And it works, maybe double check if I've missed something?

kunj1988 · 2018-09-24T05:01:21Z

@Cristiano81, yes, I got the same error while adding Date with 09/30/2088 in To field otherwise working fine. It works with max 20 years difference between From and To field.

magento-engcom-team · 2018-09-24T05:25:12Z

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label G1 Passed will be added to the issue automatically. Please, edit issue description if needed, until label G1 Passed appears.
2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add G2 Passed label to the issue by yourself.
3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
4. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

5. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
6. Add label acknowledged once verification is complete.
7. Make sure that automatic system confirms that report is acknowledged.

ghost · 2018-09-24T06:31:14Z

Hi @hostep so this is bug ? or we can just leave field empty?

kunj1988 · 2018-09-24T06:38:35Z

In my case, While we add To date more than 20 years Magento adding 0000-00-00 00:00:00 value in expiration_date field.

hostep · 2018-09-24T06:52:56Z

@engcom-backlog-nazar: the fact that the 20 year problem exist is a bug, but it seems to have already existed since Magento 2.2.0 at least (haven't tested further back).

I'm still curious about the exact problem of @Cristiano81 where it worked on 2.2.5 but no longer on 2.2.6, that part hasn't been discovered yet I believe.

Cristiano81 · 2018-09-24T07:17:22Z

@hostep the fact is very curious.
I opened this issue because we had a Magento 2.2.2 with a coupon with these settings:

After upgrade from 2.2.2 to 2.2.5 and after to 2.2.6 this coupon stopped work.
But on our test enviroment where there is the 2.2.5 version of Magento the same coupon works perfectly.
On saturday after some try with the date it starts work also on 2.2.6 ...

vdBrandtMedia · 2019-01-17T15:01:31Z

I have encountered the same issue on 2.2.5, checked the date_to value in the salesrule table but it gives a correct value of 2019-11-26

magento-engcom-team · 2019-02-12T18:04:00Z

Hi @shikhamis11. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
2. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

3. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
4. If the issue is not relevant or is not reproducible any more, feel free to close it.

scottsb · 2019-03-13T15:55:32Z

I agree with @konarshankar07 that the best/correct solution here is to change the expiration column type to a DATETIME instead of TIMESTAMP.

magento-engcom-team · 2019-03-21T16:58:28Z

Hi @henryktews. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
2. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

3. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
4. If the issue is not relevant or is not reproducible any more, feel free to close it.

thomas-avada · 2019-05-02T07:20:42Z

My client encountered this issue for one time. As far as I can tell, it is because the server configuration does not allow PUT, PATCH and DELETE request. You should contact your server guy on this and try my approach to enable all of the above request verbs.

this-adarsh · 2019-05-04T06:01:37Z

I am working on this at #dmcdindia19

magento-engcom-team · 2019-05-04T06:01:38Z

@this-adarsh thank you for joining. Please accept team invitation here and self-assign the issue.

m2-assistant · 2019-05-04T06:03:25Z

Hi @this-adarsh. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
2. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

3. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
4. If the issue is not relevant or is not reproducible any more, feel free to close it.

this-adarsh · 2019-05-04T06:05:41Z

@magento-engcom-team give me 2.3-develop instance

magento-engcom-team · 2019-05-04T06:05:42Z

Hi @this-adarsh. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team · 2019-05-04T06:06:43Z

Hi @this-adarsh, here is your Magento instance.
Admin access: https://i-18183-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

magento-engcom-team · 2019-05-29T16:30:28Z

Hi @Cristiano81. Thank you for your report.
The issue has been fixed in #22718 by @this-adarsh in 2.3-develop branch
Related commit(s):

e965f0ca8676b6e71e155843da8ebef1c65ae7da

The fix will be available with the upcoming 2.3.3 release.

…8183 magento#22718 - Merge Pull Request magento#22718 from this-adarsh/magento2:issue-18183 - Merged commits: 1. e965f0c

…8183 magento#22718

ashvinimarwal · 2019-10-01T06:55:23Z

The issue still exists in Magento 2.3.2.tried to fix it using by change timestamp to datetime in db_schema.xml file

<column xsi:type="timestamp" name="expiration_date" on_update="false" nullable="true"
                comment="Expiration Date"/>
        <column xsi:type="smallint" name="is_primary" padding="5" unsigned="true" nullable="true" identity="false"
                comment="Is Primary"/>
        <column xsi:type="timestamp" name="created_at" on_update="false" nullable="true"
                comment="Coupon Code Creation Date"/>

But still not fixed.

magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Sep 21, 2018

ghost self-assigned this Sep 24, 2018

ghost added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Sep 24, 2018

ghost added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Sep 24, 2018

ghost added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Sep 24, 2018

sdzhepa unassigned Shubham0492 Jan 11, 2019

shikhamis11 self-assigned this Feb 12, 2019

sdzhepa unassigned shikhamis11 Mar 4, 2019

scottsb mentioned this issue Mar 13, 2019

Cannot use coupon if expiration date greater than 01/19/2038 #8060

Closed

henryktews self-assigned this Mar 21, 2019

henryktews removed their assignment Mar 21, 2019

magento-engcom-team added the Event: dmcdindia1 label May 4, 2019

this-adarsh self-assigned this May 4, 2019

this-adarsh added a commit to this-adarsh/magento2 that referenced this issue May 4, 2019

Resolved issue coupon codes don't work anymore magento#18183

e965f0c

this-adarsh mentioned this issue May 4, 2019

Resolved issue coupon codes don't work anymore #18183 #22718

Merged

4 tasks

magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label May 29, 2019

magento-engcom-team closed this as completed May 29, 2019

magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this issue May 29, 2019

ENGCOM-5086: Resolved issue coupon codes don't work anymore magento#1…

bbafe0b

…8183 magento#22718

This was referenced Oct 28, 2021

Update expires_at column type from table admin_user_expiration in ord… #34462

Closed

Review the use of timestamp fields in the database, consider replacing them with datetime fields in order to avoid issues with the year 2038 and beyond #34478

Open

This comment has been minimized.

Magento 2.2.6 coupon codes don't work anymore #18183

Magento 2.2.6 coupon codes don't work anymore #18183

Comments

Cristiano81 commented Sep 21, 2018 • edited Loading

Preconditions

Steps to reproduce

Expected result

Actual result

magento-engcom-team commented Sep 21, 2018

Cristiano81 commented Sep 21, 2018

Cristiano81 commented Sep 21, 2018

magento-engcom-team commented Sep 21, 2018

magento-engcom-team commented Sep 21, 2018

Cristiano81 commented Sep 21, 2018

Cristiano81 commented Sep 21, 2018

kunj1988 commented Sep 22, 2018

Cristiano81 commented Sep 22, 2018

magento-engcom-team commented Sep 22, 2018

magento-engcom-team commented Sep 22, 2018

Cristiano81 commented Sep 22, 2018

hostep commented Sep 22, 2018

Cristiano81 commented Sep 22, 2018 • edited Loading

hostep commented Sep 22, 2018

hostep commented Sep 22, 2018

Cristiano81 commented Sep 22, 2018

hostep commented Sep 22, 2018

kunj1988 commented Sep 24, 2018 • edited Loading

magento-engcom-team commented Sep 24, 2018 • edited by ghost Loading

ghost commented Sep 24, 2018

kunj1988 commented Sep 24, 2018 • edited Loading

hostep commented Sep 24, 2018

Cristiano81 commented Sep 24, 2018 • edited Loading

vdBrandtMedia commented Jan 17, 2019

magento-engcom-team commented Feb 12, 2019

scottsb commented Mar 13, 2019

magento-engcom-team commented Mar 21, 2019

thomas-avada commented May 2, 2019

this-adarsh commented May 4, 2019

magento-engcom-team commented May 4, 2019

m2-assistant bot commented May 4, 2019

this-adarsh commented May 4, 2019

magento-engcom-team commented May 4, 2019

magento-engcom-team commented May 4, 2019

magento-engcom-team commented May 29, 2019

ashvinimarwal commented Oct 1, 2019

Cristiano81 commented Sep 21, 2018 •

edited

Loading

Cristiano81 commented Sep 22, 2018 •

edited

Loading

kunj1988 commented Sep 24, 2018 •

edited

Loading

magento-engcom-team commented Sep 24, 2018 •

edited by ghost

Loading

kunj1988 commented Sep 24, 2018 •

edited

Loading

Cristiano81 commented Sep 24, 2018 •

edited

Loading