Better grunt workflow / local theme.js

[amenk]

When installing a new theme, I would add it to

dev/tools/grunt/configs/themes.js

(according to http://devdocs.magento.com/guides/v2.0/frontend-dev-guide/css-topics/css_debug.html#grunt_prereq)

But this file is in the standard git ignore and would be overwritten when doing a composer update (if Magento is installed via composer)

How can we fix this?

Maybe an additional file custom_themes.js which is included if it exists?

[amenk]

see PR #1982

[amenk]

I am not so happy with my pull request. I was thinking about auto-detecting the installed themes for grunt.
But I am not sure if we also can auto detect the locale which is needed for less generation.
What do you think?

[amenk]

I updated my PR #1982 and I am more happy with it now :) - please have a look

[guz-anton]

Just a notice: internal ticket MAGETWO-55345 has been created.

[piotrekkaminski]

Thank you for your submission.

We recently made some changes to the way we process GitHub submissions to more quickly identify and respond to core code issues.

Feature Requests and Improvements should now be submitted to the new Magento 2 Feature Requests and Improvements forum (see details here).

We are closing this GitHub ticket and have moved your request to the new forum.

[guz-anton]

Hi @amenk ,
We did not forget about the issue. Recently we introduced small improvement in current develop branch (it should be available in 2.2).

From now you have ability to place local
dev/tools/grunt/configs/themes.loc.js config file.

I hope it solves your task.

[hostep]

@guz-anton: @amenk is really correct in his comment on this change. Using .loc instead of .local is just stupid and potentially very confusing.

So if you could please get the developers to change this before this is shipped in a new release, that would be great. Otherwise if you only change it after it was shipped in a new release, it would mean that we (yet again) have to change our workflows.

Thanks!

Completely offtopic, but it made me think of this:

There are only two hard things in Computer Science: cache invalidation and naming things.

-- Phil Karlton