Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database Media Storage - Design Config fails to save transactional email logo correctly #21672

Closed
gwharton opened this issue Mar 10, 2019 · 6 comments
Assignees
Labels
Component: Config Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@gwharton
Copy link
Contributor

gwharton commented Mar 10, 2019

Preconditions (*)

  1. 2.2-develop or 2.3-develop

Steps to reproduce (*)

  1. Setup Magento
  2. Change media storage mode to database
  3. Synchronize
  4. Save Settings
  5. Content->Configuration->Edit->Transactional Emails
  6. Upload New Image (but don't save)
  7. Verify temporary email logo exists in pub/media
  8. Verify temporary email logo exists in database
  9. Save Config
  10. Verify email logo exists in pub/media
  11. Verify email logo exists in database

Expected result (*)

  1. After saving the config, the email logo image should be present in both database and filesystem

Actual result (*)

  1. Email logo is not present in database

Step 7

www-data@dev:~/dev2$ find pub/media -name *.jpg
pub/media/tmp/design/file/Forklift.200x100.jpg

Step 8

www-data@dev:~/dev2$ mysql dev2_magento -e "select filename,directory from media_storage_file_storage"
+----------------------------------+-----------------+
| filename                         | directory       |
+----------------------------------+-----------------+
| preview_image_5c85077ebb298.jpeg | theme/preview   |
| preview_image_5c85077ed85e1.jpeg | theme/preview   |
| Forklift.200x100.jpg             | tmp/design/file |
+----------------------------------+-----------------+

Step 10

www-data@dev:~/dev2$ find pub/media -name *.jpg
pub/media/email/logo/stores/1/Forklift.200x100.jpg

Step 11

www-data@dev:~/dev2$ mysql dev2_magento -e "select filename,directory from media_storage_file_storage"
+----------------------------------+-----------------+
| filename                         | directory       |
+----------------------------------+-----------------+
| preview_image_5c85077ebb298.jpeg | theme/preview   |
| preview_image_5c85077ed85e1.jpeg | theme/preview   |
| Forklift.200x100.jpg             | tmp/design/file |
+----------------------------------+-----------------+

Step 11 has failed. The file is still in the database in the temporary location. It was not changed when the config was saved.

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Mar 10, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Mar 10, 2019

Hi @gwharton. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@gwharton do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Mar 11, 2019

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: Config Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Mar 11, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-backlog-nazar
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98682, MAGETWO-98683 were created

Issue Available: @engcom-backlog-nazar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Mar 14, 2019
@ghost ghost added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Mar 14, 2019
@ghost ghost assigned gwharton Mar 27, 2019
@gwharton
Copy link
Contributor Author

gwharton commented Jun 2, 2019

#21675 and #21676 have been merged. Closing.

@gwharton gwharton closed this as completed Jun 2, 2019
@magento-engcom-team
Copy link
Contributor

Hi @gwharton. Thank you for your report.
The issue has been fixed in #21674 by @gwharton in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.3 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jun 7, 2019
@ihor-sviziev ihor-sviziev added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jun 7, 2019
@magento-engcom-team
Copy link
Contributor

Hi @gwharton. Thank you for your report.
The issue has been fixed in #21673 by @gwharton in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.10 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Config Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

3 participants