Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.2][Backport] Database Media Storage - Transactional Emails will now extract image from database in Database Media Storage mode #21673

Merged
merged 3 commits into from Jul 4, 2019

Conversation

gwharton
Copy link
Contributor

@gwharton gwharton commented Mar 10, 2019

Original PR (*)

  1. [2.3] Database Media Storage - Transactional Emails will now extract image from database in Database Media Storage mode #21674

Description (*)

If the email logo does not exist in pub/media and we are in database storage mode, then magento should copy the image file from database to local pub/media prior to continuing.

Fixed Issues (if relevant)

  1. Database Media Storage - Transaction emails logo not used when pub/media cleared #21671: Database Media Storage - Transaction emails logo not used when pub/media cleared

Manual testing scenarios (*)

  1. Setup Magento
  2. Change media storage mode to database
  3. Synchronize
  4. Save Settings
  5. Set store General Contact email address to valid email
  6. Set email logo (Content->Configuration->Edit->Transactional Emails)
  7. Clear Cache
  8. Verify email logo exists in database <- This will fail on 2.2-develop due to Database Media Storage - Design Config fails to save transactional email logo correctly #21672
  9. Verify email logo exists in pub/media
  10. On Frontend, subscribe to newsletter
  11. Verify newsletter email contains logo
  12. Clear pub/media, simulating a new cluster node being used
  13. On Frontend, subscribe to newsletter (need to use new email address, or delete 1st address in backend first)
  14. Verify newsletter email contains logo

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @gwharton. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@gwharton gwharton changed the title [2.2][Backport] Transactional Emails will now extract image from database in Database Media Storage mode [2.2][Backport] Database Storage Mode - Transactional Emails will now extract image from database in Database Media Storage mode Mar 10, 2019
@gwharton gwharton changed the title [2.2][Backport] Database Storage Mode - Transactional Emails will now extract image from database in Database Media Storage mode [2.2][Backport] Database Media Storage - Transactional Emails will now extract image from database in Database Media Storage mode Mar 10, 2019
@gwharton
Copy link
Contributor Author

Hold pending resolution to #21672, otherwise difficult to reproduce in isolation and prove.

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5302 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Jun 18, 2019
@engcom-Delta
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Jul 4, 2019

Hi @gwharton, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jul 4, 2019
…mails will now extract image from database in Database Media Storage mode #21673
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.10 milestone Jul 4, 2019
@gwharton gwharton deleted the 2.2-develop-dbmediastorage3 branch July 6, 2019 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants