Incorrect constructor of Magento\Sales\Model\Order\Address\Validator

[Bartlomiejsz]

Summary (*)

Tested on 2.3, but exactly same logic is included in this constructor on 2.2-develop branch.
Constructor of Magento\Sales\Model\Order\Address\Validator includes logic and should not. The reason of it is that if this class is injected in constructor in Cli Command in some custom module, installation of Magento fails.

Examples (*)

1. Add custom module with Cli Command in which Magento\Sales\Model\Order\Address\Validator is injected
2. Try to install Magento from scratch using Cli.
3. See following error: Base table or view not found: 1146 Table 'database.eav_entity_type' doesn't exist, query was: SELECT main_table.* FROM eav_entity_typeASmain_table"

Proposed solution

I'm preparing PR for this one.

[magento-engcom-team]

Hi @Bartlomiejsz. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@Bartlomiejsz do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[magento-engcom-team]

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• Next steps are available in case you are a member of Community Maintainers.

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

✅ Confirmed by @engcom-backlog-nazar
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98657 were created

Issue Available: @engcom-backlog-nazar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[MaksymGrom]

@Bartlomiejsz Hello, CLI in Magento loads all Command classes and them injections
So you should use Proxy to avoid loading Repositories and other classes with the same problem
Please change your injection. (while issue is not resolved)
Magento\Sales\Model\Order\Address\Validator => Magento\Sales\Model\Order\Address\Validator\Proxy

Also, you can change the injection attribute via di.xml.
You can see this way in \Magento\Catalog\Console\Command\ImagesResizeCommand
magento/module-catalog/etc/di.xml:557

[Bartlomiejsz]

@MaksymGrom you're right, it can be handled using proxy, but still such logic should not be included in constructor so I hope it will be merged soon.
Thank you for response!

[magento-engcom-team]

Hi @Bartlomiejsz. Thank you for your report.
The issue has been fixed in #21693 by @Bartlomiejsz in 2.3-develop branch
Related commit(s):

• 28b047ec570fce2752960668e5b4e6eda21593b4
• b92ffa24299d32b62d2a211aa7756d866ad13154
• fda4377384169d385a04057e7edf2f1ac32bc5ec
• b2004c3f74f7cdd2654986f056f6ba8d8beaa5ee
• b86f981ad04f63c7ca8d2c3ca5f3b4abe999ca4d
• 73d88aaeaa7da30c68608d7f048b7b88557e936d
• 9c7fbfdc24380fc3174d313bcf5c12ca381e9313
• e09429f7cca09d91245c0999cb043e7845d4fa74

The fix will be available with the upcoming 2.3.2 release.

[magento-engcom-team]

Hi @Bartlomiejsz. Thank you for your report.
The issue has been fixed in #21719 by @Bartlomiejsz in 2.2-develop branch
Related commit(s):

• 068eedf0b8fb069df8e8432e8b78d3a0dff33110
• 8a4cfa4eac8b5d18d1c9b30655dbacabce9d9d53
• 43cc9a4d3ab36e292382ca06c8256b47452cfed3
• f77f54dac19e6d9853b0e34a4bda1b39fd62fd3c
• cece0869efc4333abdd410f0482d0d6586a04ce8
• 67b1d0a12fea5f46073ca4e4133e5debd3bf6ede

The fix will be available with the upcoming 2.2.9 release.