Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview Email Template cut off #23754

Closed
vincent2090311 opened this issue Jul 18, 2019 · 37 comments
Closed

Preview Email Template cut off #23754

vincent2090311 opened this issue Jul 18, 2019 · 37 comments
Labels
Component: Admin Component: Email Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@vincent2090311
Copy link

vincent2090311 commented Jul 18, 2019

Preconditions (*)

  1. Magento 2.3.2
    2.PHP 7.1
    3.Nginx 1.17

Steps to reproduce (*)

1.Add new email template under marketing > Email Templates
2.Load any default magento email template > save without change
3.Go to email templates grid > click preview

Expected result (*)

Can view full email templates

Actual result (*)

  1. Preview screen is cut off
    Capture 2019-07-18 at 10 36 35
@m2-assistant
Copy link

m2-assistant bot commented Jul 18, 2019

Hi @vincent2090311. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@vincent2090311 do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jul 18, 2019
@ajijshekh123 ajijshekh123 self-assigned this Jul 18, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jul 18, 2019

Hi @ajijshekh123. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ajijshekh123 ajijshekh123 added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: Admin Component: Email labels Jul 18, 2019
@ajijshekh123
Copy link

Give me @magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @ajijshekh123. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @ajijshekh123, here is your Magento instance.
Admin access: https://i-23754-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@ajijshekh123
Copy link

Give me @magento give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @ajijshekh123. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@ajijshekh123
Copy link

@vincent2090311 - I have reviewed this issue in Magento 2.3 Instance. I have loaded the different Email template Ex:- Create an Account, Order, Credit, Invoice. All the Email template is proper loading.

See attached the screenshot:

2019-07-18 (1)

2019-07-18

@vincent2090311 - Let me know if you have reproduced this issue in Fresh Magento 2.3 Instance. If you didn't find this issue again let me know so I will close this issue.

@ajijshekh123 ajijshekh123 added Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Progress: needs update labels Jul 18, 2019
@vincent2090311
Copy link
Author

@ajijshekh123
I checked on develop instance and its not using iframe so it doesnt have issue. Pls try to setup new magento installation on your PC, you will see preview email template is iframe

@ajijshekh123
Copy link

@vincent2090311 - This issue I can review only Magento instance which is given by the Magento Team. If this issue is reproduced in Default Magento Instance I will add the tag reproduce otherwise I can't test Magento instance which is available in my system.

Thanks.

@ajijshekh123
Copy link

@vincent2090311 - feel free to reopen this issue when you will reproduce this issue in fresh Magento Instance.

@vincent2090311
Copy link
Author

@ajijshekh123
Im still able to replicate issue on fresh magento 2.3.2 installation
Screen Shot 2019-07-19 at 7 34 57 PM

@ajijshekh123
Copy link

Give me @magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @ajijshekh123. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @ajijshekh123, here is your Magento instance.
Admin access: https://i-23754-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@ajijshekh123
Copy link

@vincent2090311 - Again, Not able to Reproduce.

2019-07-19 (3)

@adamlukaszewski
Copy link

Hi same here. I have also the same issue. E-Mail preview will be cut off due the iframe height.

image

I am running on a 2.3.2 instance (community).

Here is the generated HTML code (iframe available):

image

@vincent2090311
Copy link
Author

@ajijshekh123
Could you re-open this issue? Not just me face the issue, other people get the same issue with me.

@ajijshekh123
Copy link

Okay @vincent2090311

@ajijshekh123 ajijshekh123 reopened this Jul 30, 2019
@ghost ghost unassigned ajijshekh123 Jul 30, 2019
@engcom-Charlie engcom-Charlie self-assigned this Jul 30, 2019
@hoangnm89
Copy link

I'm getting the same issue with 2.3.2 fresh installation.
i tried on 2.3.1, no issue.

i think this is a clue for who want to fix the issue, sorry i have not tried yet.

2.3.1 adminhtml_email_template_preview.xml
https://github.com/magento/magento2/blob/2.3.1/app/code/Magento/Email/view/adminhtml/layout/adminhtml_email_template_preview.xml

<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" layout="admin-1column" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
    <update handle="empty" />
    <body>
        <referenceContainer name="root">
            <block name="preview.page.content" class="Magento\Framework\View\Element\Template" template="Magento_Email::template/preview.phtml">
                <block class="Magento\Email\Block\Adminhtml\Template\Preview" name="content" as="content"/>
            </block>
        </referenceContainer>
    </body>
</page>

2.3.2 adminhtml_email_template_preview.xml
https://github.com/magento/magento2/blob/2.3.2/app/code/Magento/Email/view/adminhtml/layout/adminhtml_email_template_preview.xml

<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" layout="admin-1column" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
    <body>
        <attribute name="id" value="html-body"/>
        <attribute name="class" value="preview-window"/>
        <referenceContainer name="backend.page" remove="true"/>
        <referenceContainer name="menu.wrapper" remove="true"/>
        <referenceContainer name="root">
            <block name="preview.page.content" class="Magento\Backend\Block\Page" template="Magento_Email::preview/iframeswitcher.phtml"/>
        </referenceContainer>
    </body>
</page>

@engcom-Charlie engcom-Charlie removed Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Progress: needs update labels Jul 30, 2019
@engcom-Charlie
Copy link
Contributor

I reproduce this issue on:
2.3-develop
image

2.3.2
image

Iframe height is so small. I confirm this issue.

@engcom-Charlie engcom-Charlie added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Jul 30, 2019
@ghost ghost unassigned engcom-Charlie Jul 30, 2019
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jul 30, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Charlie
Thank you for verifying the issue. Based on the provided information internal tickets MC-18734 were created

Issue Available: @engcom-Charlie, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@edenduong edenduong self-assigned this Aug 15, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 15, 2019

Hi @edenduong. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@ghost ghost unassigned edenduong Sep 27, 2019
@BrentRobert
Copy link
Contributor

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @BrentRobert. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @BrentRobert, here is your Magento instance.
Admin access: https://i-23754-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

magento-engcom-team added a commit that referenced this issue Oct 14, 2019
 - Merge Pull Request #24881 from BrentRobert/magento2:bugfix/23754
 - Merged commits:
   1. 3374a5a
@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Oct 30, 2019
@magento-engcom-team
Copy link
Contributor

Hi @vincent2090311. Thank you for your report.
The issue has been fixed in #24881 by @BrentRobert in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.4 release.

@AndyJAllen
Copy link

Where is that css file located in a composer installation? I don't even see a css folder in \vendor\magento\module-backend\view\adminhtml\web

@hemendrametawolf
Copy link

I am still facing this issue on magento 2.4.4-p1

@hemendrametawolf
Copy link

@magento give me 2.4.4-p1 instance

@magento-deployment-service
Copy link

Hi @hemendrametawolf. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @hemendrametawolf, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@hemendrametawolf
Copy link

@magento give me 2.4.4 instance

@magento-deployment-service
Copy link

Hi @hemendrametawolf. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @hemendrametawolf, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@AndyJAllen
Copy link

Do yourself a favor and look at WordPress + WooCommerce plugin. Magento is a disaster and many of us jumped ship. Many free & cheap modules to hook into a barebones e-commerce site to do almost anything a business would need. I also recommend Flatsome theme for their very nice UX builder feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Admin Component: Email Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

10 participants